You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Roman Shaposhnik (JIRA)" <ji...@apache.org> on 2011/09/21 03:23:10 UTC
[jira] [Created] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
the location and name of the flume's PID file needs to be tweakable
-------------------------------------------------------------------
Key: FLUME-766
URL: https://issues.apache.org/jira/browse/FLUME-766
Project: Flume
Issue Type: Bug
Components: Shell
Affects Versions: v0.9.4
Reporter: Roman Shaposhnik
Priority: Minor
Currently it is hardcoded in flume shell script:
MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
.....
MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Shaposhnik updated FLUME-766:
-----------------------------------
Attachment: FLUME-766-2.patch.txt
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766-1.patch.txt, FLUME-766-2.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112817#comment-13112817 ]
Jonathan Hsieh commented on FLUME-766:
--------------------------------------
Roman,
Can you add some comments at the top of the script that explains the new variables being pulled in?
I'll give it a quick test.
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112827#comment-13112827 ]
Roman Shaposhnik commented on FLUME-766:
----------------------------------------
sure. let me update the patch before you do the testing.
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned FLUME-766:
------------------------------------
Assignee: Roman Shaposhnik
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766-1.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Shaposhnik updated FLUME-766:
-----------------------------------
Status: Patch Available (was: Open)
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated FLUME-766:
---------------------------------
Resolution: Fixed
Fix Version/s: v0.9.5
Status: Resolved (was: Patch Available)
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Fix For: v0.9.5
>
> Attachments: FLUME-766-1.patch.txt, FLUME-766-2.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112866#comment-13112866 ]
Jonathan Hsieh commented on FLUME-766:
--------------------------------------
seems fine, please add some comments on the top of the file about FLUME_PID_DIR, MASTERPID, NODEPID, and FLUME_IDENT_STRING?
Thanks, Jon.
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766-1.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Shaposhnik updated FLUME-766:
-----------------------------------
Attachment: FLUME-766-1.patch.txt
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766-1.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112892#comment-13112892 ]
Jonathan Hsieh commented on FLUME-766:
--------------------------------------
patch FLUME-766-2.patch.txt lgtm.
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766-1.patch.txt, FLUME-766-2.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-766) the location and name of the flume's
PID file needs to be tweakable
Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Shaposhnik updated FLUME-766:
-----------------------------------
Attachment: FLUME-766.patch.txt
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$ -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira