You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/31 07:16:03 UTC
[GitHub] [flink] docete opened a new pull request #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
docete opened a new pull request #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573
…ld incorrect results
## What is the purpose of the change
Because CALCITE-3881, TIMESTAMPDIFF/TIMESTAMPADD yields incorrect results. This PR is a temporary solution to fix this before CALCITE-3881 is fixed.
## Brief change log
- dfd2474 implements addMonths/subtractMonths in flink side.
## Verifying this change
This change added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156975397",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156975397) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866)
* 2d69f4f04947f69e776961d77207edebdb07e10b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156975397",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157011017",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6878",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d69f4f04947f69e776961d77207edebdb07e10b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157011017) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung closed pull request #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
KurtYoung closed pull request #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156975397",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156975397) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156975397",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157011017",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6878",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156975397) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866)
* 2d69f4f04947f69e776961d77207edebdb07e10b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157011017) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156975397",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157011017",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
}, {
"hash" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6878",
"triggerID" : "2d69f4f04947f69e776961d77207edebdb07e10b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d69f4f04947f69e776961d77207edebdb07e10b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157011017) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606446561
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4 (Tue Mar 31 07:18:07 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11573: [FLINK-16823][table-planner-blink] Fix TIMESTAMPDIFF/TIMESTAMPADD yie…
URL: https://github.com/apache/flink/pull/11573#issuecomment-606453288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
}, {
"hash" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156975397",
"triggerID" : "dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfd2474f4258e35613f301ed9daeb9ed3c8a2cb4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156975397) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6866)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services