You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2022/07/14 04:08:51 UTC
[incubator-nuttx] 02/08: drivers: Convert DEBUGASSERT(false) into more intuitive DEBUGPANIC()
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e999708b314f646e01525cad3c1d5a912be8ddd2
Author: Gustavo Henrique Nihei <gu...@espressif.com>
AuthorDate: Wed Jul 13 14:34:54 2022 -0300
drivers: Convert DEBUGASSERT(false) into more intuitive DEBUGPANIC()
Signed-off-by: Gustavo Henrique Nihei <gu...@espressif.com>
---
drivers/1wire/1wire.c | 2 +-
drivers/can/can.c | 4 ++--
drivers/motor/foc/foc_dev.c | 2 +-
drivers/net/encx24j600.c | 2 +-
drivers/net/lan91c111.c | 2 +-
drivers/power/bq2429x.c | 2 +-
drivers/usbdev/cdcecm.c | 2 +-
drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c | 4 ++--
8 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/1wire/1wire.c b/drivers/1wire/1wire.c
index f1fbfed9ff..ae1fbe4948 100644
--- a/drivers/1wire/1wire.c
+++ b/drivers/1wire/1wire.c
@@ -155,7 +155,7 @@ static int onewire_pm_prepare(FAR struct pm_callback_s *cb, int domain,
if (nxsem_get_value(&master->devsem.sem, &sval) < 0)
{
- DEBUGASSERT(false);
+ DEBUGPANIC();
return -EINVAL;
}
diff --git a/drivers/can/can.c b/drivers/can/can.c
index cb9316b932..6793af58ff 100644
--- a/drivers/can/can.c
+++ b/drivers/can/can.c
@@ -1165,7 +1165,7 @@ static int can_poll(FAR struct file *filep, FAR struct pollfd *fds,
if (ret < 0)
{
- DEBUGASSERT(false);
+ DEBUGPANIC();
goto return_with_irqdisabled;
}
else if (sval > 0)
@@ -1406,7 +1406,7 @@ int can_receive(FAR struct can_dev_s *dev, FAR struct can_hdr_s *hdr,
sval = 0;
if (nxsem_get_value(&fifo->rx_sem, &sval) < 0)
{
- DEBUGASSERT(false);
+ DEBUGPANIC();
#ifdef CONFIG_CAN_ERRORS
/* Report unspecified error */
diff --git a/drivers/motor/foc/foc_dev.c b/drivers/motor/foc/foc_dev.c
index 75ee6f3e35..970314f7a8 100644
--- a/drivers/motor/foc/foc_dev.c
+++ b/drivers/motor/foc/foc_dev.c
@@ -760,7 +760,7 @@ static int foc_notifier(FAR struct foc_dev_s *dev,
{
/* This is a critical fault */
- DEBUGASSERT(0);
+ DEBUGPANIC();
/* Set timeout fault if not in debug mode */
diff --git a/drivers/net/encx24j600.c b/drivers/net/encx24j600.c
index fcd6a68758..1923b11105 100644
--- a/drivers/net/encx24j600.c
+++ b/drivers/net/encx24j600.c
@@ -1760,7 +1760,7 @@ static void enc_rxabtif(FAR struct enc_driver_s *priv)
descr = (FAR struct enc_descr_s *)sq_next(descr);
}
- DEBUGASSERT(false);
+ DEBUGPANIC();
#endif
descr = (FAR struct enc_descr_s *)sq_peek(&priv->rxqueue);
diff --git a/drivers/net/lan91c111.c b/drivers/net/lan91c111.c
index 6753bb5b51..8587b026ab 100644
--- a/drivers/net/lan91c111.c
+++ b/drivers/net/lan91c111.c
@@ -785,7 +785,7 @@ static void lan91c111_txdone(FAR struct net_driver_s *dev)
}
else
{
- DEBUGASSERT(0);
+ DEBUGPANIC();
}
}
diff --git a/drivers/power/bq2429x.c b/drivers/power/bq2429x.c
index 418f883cde..de66d4b359 100644
--- a/drivers/power/bq2429x.c
+++ b/drivers/power/bq2429x.c
@@ -744,7 +744,7 @@ static int bq2429x_health(FAR struct battery_charger_dev_s *dev,
break; /* No return, check for other faults */
default:
- DEBUGASSERT(false);
+ DEBUGPANIC();
*health = BATTERY_HEALTH_UNKNOWN;
return OK;
}
diff --git a/drivers/usbdev/cdcecm.c b/drivers/usbdev/cdcecm.c
index 4563498f24..3bf51ab19f 100644
--- a/drivers/usbdev/cdcecm.c
+++ b/drivers/usbdev/cdcecm.c
@@ -1408,7 +1408,7 @@ static void cdcecm_mkepdesc(int epidx,
break;
default:
- DEBUGASSERT(false);
+ DEBUGPANIC();
}
}
diff --git a/drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c b/drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c
index ffcdd844dc..dc6da7f45d 100644
--- a/drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c
+++ b/drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c
@@ -565,7 +565,7 @@ int bcmf_core_upload_firmware(FAR struct bcmf_sdio_dev_s *sbus)
#endif
default:
- DEBUGASSERT(false);
+ DEBUGPANIC();
}
nxsig_usleep(50 * 1000);
@@ -668,7 +668,7 @@ int bcmf_core_upload_firmware(FAR struct bcmf_sdio_dev_s *sbus)
#endif
default:
- DEBUGASSERT(false);
+ DEBUGPANIC();
}
return OK;