[GitHub] [avro] eerhardt commented on a change in pull request #1013: AVRO-2983: Set Span length of ArrayPool Rent buffer

[GitBox <gi...@apache.org>]

eerhardt commented on a change in pull request #1013:
URL: https://github.com/apache/avro/pull/1013#discussion_r547356202



##########
File path: lang/csharp/src/apache/test/IO/BinaryCodecTests.cs
##########
@@ -214,6 +213,23 @@ public void TestString(string n, int overhead)
             TestSkip(n, (Decoder d) => d.SkipString(), (Encoder e, string t) => e.WriteString(t), overhead + n.Length);
         }
 
+#if NETCOREAPP3_1

Review comment:
       How do you feel about also adding the test from https://issues.apache.org/jira/secure/attachment/13017389/AVRO-3005.patch ?
   
   That way `net461` gets test coverage for a longer string as well.
   
   BTW - AVRO-3005 appears to be a duplicate of AVRO-2983.
   
   ```diff
            [TestCase("", 1)]
            [TestCase("hello", 1)]
            [TestCase("1234567890123456789012345678901234567890123456789012345678901234", 2)]
   +        [TestCase("01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456", 2)]
            public void TestString(string n, int overhead)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org