You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/08 01:33:51 UTC
Review Request 16712: This will make timestamps toggle between relative and
absolute values (for easy cut/paste).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Diffs
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31327
-----------------------------------------------------------
src/webui/master/static/directives/timestamp.html
<https://reviews.apache.org/r/16712/#comment59801>
Could we go with the HTML5 <time> tag and give it "cursor: pointer; border-bottom: 1px dotted gray" to make it look clickable?
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16712/#comment59800>
Include a radix when calling parseInt:
parseInt(date, 10)
- Ross Allen
On Jan. 8, 2014, 12:37 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 12:37 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31330
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Jan. 8, 2014, 1:37 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:37 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31483
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16712/#comment59980>
Yup, that's the plan. I'm working on a couple more `m-` prefixed directives right now.
- Thomas Rampelberg
On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:50 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: Enabled toggling between relative and absolute
timestamps by clicking on them.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 12:14 a.m.)
Review request for mesos and Ross Allen.
Summary (updated)
-----------------
Enabled toggling between relative and absolute timestamps by clicking on them.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description (updated)
-------
Enabled toggling between relative and absolute timestamps by clicking on them.
Note that your preference for which type you'd like is remembered
between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Review: http://reviews.apache.org/r/16712
Diffs (updated)
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Ross Allen <ro...@mesosphere.io>.
> On Jan. 9, 2014, 11:49 p.m., Ross Allen wrote:
> > src/webui/master/static/directives/timestamp.html, line 4
> > <https://reviews.apache.org/r/16712/diff/6/?file=419925#file419925line4>
> >
> > When a Task is created in the STAGING state, it has no start time. When timestamps are set to the absolute setting, it prints that Batman song: "NaNNaNNaNNaN:NaNNaNNaN".
> >
> > This should print nothing if the value is null or undefined.
https://www.dropbox.com/s/aaj6jayzxxn5qe6/Screenshot%202014-01-09%2015.51.09.png
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31487
-----------------------------------------------------------
On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:50 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31487
-----------------------------------------------------------
src/webui/master/static/directives/timestamp.html
<https://reviews.apache.org/r/16712/#comment59993>
When a Task is created in the STAGING state, it has no start time. When timestamps are set to the absolute setting, it prints that Batman song: "NaNNaNNaNNaN:NaNNaNNaN".
This should print nothing if the value is null or undefined.
- Ross Allen
On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:50 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 9, 2014, 10:50 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Review: http://reviews.apache.org/r/16712
Diffs (updated)
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 9, 2014, 9:33 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/js/app.js, line 195
> > <https://reviews.apache.org/r/16712/diff/5/?file=418329#file418329line195>
> >
> > This is fantastic! Not being well enough versed in Angular, what's the 'm' prefix signify?
It is just a way to namespace directives. Angular core uses its own prefix (ngRepeat for example) and it seemed to be a good idea.
> On Jan. 9, 2014, 9:33 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 451
> > <https://reviews.apache.org/r/16712/diff/5/?file=418322#file418322line451>
> >
> > Please line the '\' up with the other ones.
That's what I get for using only spaces.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31462
-----------------------------------------------------------
On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:50 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 9, 2014, 9:33 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/js/app.js, line 195
> > <https://reviews.apache.org/r/16712/diff/5/?file=418329#file418329line195>
> >
> > This is fantastic! Not being well enough versed in Angular, what's the 'm' prefix signify?
>
> Thomas Rampelberg wrote:
> It is just a way to namespace directives. Angular core uses its own prefix (ngRepeat for example) and it seemed to be a good idea.
Got it, so I'll assume 'm-' signifies "Mesos" directives then right?
> On Jan. 9, 2014, 9:33 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 451
> > <https://reviews.apache.org/r/16712/diff/5/?file=418322#file418322line451>
> >
> > Please line the '\' up with the other ones.
>
> Thomas Rampelberg wrote:
> That's what I get for using only spaces.
Spaces are fine! Just keep them all aligned please.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31462
-----------------------------------------------------------
On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:50 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31462
-----------------------------------------------------------
Ship it!
That's a lot of red, my favorite kind of review! ;)
src/Makefile.am
<https://reviews.apache.org/r/16712/#comment59958>
Please line the '\' up with the other ones.
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16712/#comment59959>
This is fantastic! Not being well enough versed in Angular, what's the 'm' prefix signify?
- Benjamin Hindman
On Jan. 8, 2014, 1:41 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:41 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:41 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Review: http://reviews.apache.org/r/16712
Diffs (updated)
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:37 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Review: http://reviews.apache.org/r/16712
Diffs (updated)
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:35 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Review: http://reviews.apache.org/r/16712
Diffs (updated)
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:31 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description (updated)
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Review: http://reviews.apache.org/r/16712
Diffs (updated)
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 8, 2014, 1:22 a.m., Ross Allen wrote:
> > src/webui/master/static/js/app.js, line 207
> > <https://reviews.apache.org/r/16712/diff/1/?file=418241#file418241line207>
> >
> > Reference localStorage from the injected $window here too.
Because localStorage is supported IE8 up, there's no reason to check for its existence.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31328
-----------------------------------------------------------
On Jan. 8, 2014, 1:31 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:31 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
> Review: http://reviews.apache.org/r/16712
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/css/mesos.css 083b5964f6fe57fc4dba11d8feaca822903059c1
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/#review31328
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16712/#comment59802>
Reference localStorage from the injected $window here too.
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16712/#comment59803>
Need to check for existence of localStorage here too and reference it from the injected $window.
- Ross Allen
On Jan. 8, 2014, 12:37 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16712/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 12:37 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-789
> https://issues.apache.org/jira/browse/mesos-789
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Note that your preference for which type you'd like is remembered between sessions.
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 12:37 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-789
https://issues.apache.org/jira/browse/mesos-789
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Diffs
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16712: This will make timestamps toggle between relative
and absolute values (for easy cut/paste).
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16712/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 12:37 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Note that your preference for which type you'd like is remembered between sessions.
Issue: https://issues.apache.org/jira/browse/MESOS-789
Diffs
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16712/diff/
Testing
-------
Thanks,
Thomas Rampelberg