You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/08/31 06:07:50 UTC

[GitHub] [orc] wgtmac opened a new pull request, #1607: ORC-1315: [C++] Fix byte to integer conversions fail on platforms with unsigned char type

wgtmac opened a new pull request, #1607:
URL: https://github.com/apache/orc/pull/1607

   ### What changes were proposed in this pull request?
   
   This patch adds static_cast for the char type cast in RLE/ColumnReader.
   
   ### Why are the changes needed?
   
   For the context of [ORC-1315](https://issues.apache.org/jira/browse/ORC-1315), this patch fixes signed char to unsigned char conversions fail where char is by default unsigned.
   
   ### How was this patch tested?
   
   No new tests were added.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac closed pull request #1607: ORC-1315: [C++] Fix byte to integer conversions fail on platforms with unsigned char type

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed pull request #1607: ORC-1315: [C++] Fix byte to integer conversions fail on platforms with unsigned char type
URL: https://github.com/apache/orc/pull/1607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org