You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2024/02/24 15:08:22 UTC
[I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
advancedxy opened a new issue, #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104
### What is the problem the feature request solves?
Currently, the backtrace is only added when rust panics.
However, when the exception is thrown back to JVM side. The error msg sometimes might be that helpful. It would be ideal to get the backtrace for the rust error as where.
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1967836075
I'll check how it works with the Comet but for DF the quick doc to enable the backtrace is https://arrow.apache.org/datafusion/user-guide/example-usage.html#enable-backtraces
Basically if you set the backtrace it should show the backtrace for most cases, the coverage on DF still getting improved.
The backtrace will show rootcause within DF, however if the error happens on arrow-rs side, this is not covered on their side.
In this case we can only go to arrow-rs entrypoint and then debug manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1962475469
I remember we intentionally trim stack trace to reduce binary size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include Rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead closed issue #104: Include Rust's native stack trace in CometNativeException
URL: https://github.com/apache/arrow-datafusion-comet/issues/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1963057489
I think we looked into this before. The problem is a large part of the errors are originated from Arrow or DF. @comphead has worked on this in DF, see https://github.com/apache/arrow-datafusion/issues/7360.
> I remember we intentionally trim stack trace to reduce binary size.
Yes we did that for release profiles, see https://github.com/apache/arrow-datafusion-comet/blob/main/core/Cargo.toml#L96. For debug profiles, the backtrace should still contain full information including the file names and line numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1962788066
If possible, then yes, I think it is good idea to add stack trace for debugging.
I remember we have discussed before and tried it but seems not working as the config is fixed.
Maybe I misremembered it. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1962782038
Seems reasonable to trim stack trace in production.
Maybe we can enable stack trace in the debug build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1963207623
> @comphead has worked on this in DF, see https://github.com/apache/arrow-datafusion/issues/7360. We could probably apply the same changes to Comet.
Sounds great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Include Rust's native stack trace in CometNativeException [arrow-datafusion-comet]
Posted by "snmvaughan (via GitHub)" <gi...@apache.org>.
snmvaughan commented on issue #104:
URL: https://github.com/apache/arrow-datafusion-comet/issues/104#issuecomment-1973954486
There were examples where the inclusion of the panic backtrace with the Exception was very helpful. I can understand limiting the length/size of the resulting stacktrace, but there is a lot of utility in including at least some of the information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org