You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/09/09 03:54:43 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

julianhyde commented on a change in pull request #2141:
URL: https://github.com/apache/calcite/pull/2141#discussion_r485321623



##########
File path: core/src/main/java/org/apache/calcite/rex/RexCall.java
##########
@@ -80,7 +80,6 @@ protected RexCall(
     this.nodeCount = RexUtil.nodeCount(1, this.operands);
     assert op.getKind() != null : op;
     assert op.validRexOperands(operands.size(), Litmus.THROW) : this;
-    assert op.kind != SqlKind.IN || this instanceof RexSubQuery;

Review comment:
       No, this assertion is needed. We do not support IN in RexCall.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org