[GitHub] [druid] imply-cheddar commented on a diff in pull request #13426: SQL test framework extensions

[GitBox <gi...@apache.org>]

imply-cheddar commented on code in PR #13426:
URL: https://github.com/apache/druid/pull/13426#discussion_r1039119271


##########
core/src/main/java/org/apache/druid/guice/DruidSecondaryModule.java:
##########
@@ -36,6 +36,7 @@
 import javax.validation.Validator;
 import java.util.Properties;
 
+@LazySingleton

Review Comment:
   So...  thinking about this, I realize that we *could* use such an annotation to require explicit bindings.  We could have an `@RequireExplicitBinding` scope annotation that would effectively throw an exception if it actually gets called.  This could be useful for any object that we expect to be explicitly bound.  If we did that, then the tests would need to have a way to explicitly bind that they expect this to be instantiated, maybe that's a good path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org