You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Clint Checketts (JIRA)" <ji...@apache.org> on 2010/08/27 16:27:54 UTC

[jira] Created: (WICKET-3019) Add getPath to MarkupExceptions to aid in locatin affected components

Add getPath to MarkupExceptions to aid in locatin affected components
---------------------------------------------------------------------

                 Key: WICKET-3019
                 URL: https://issues.apache.org/jira/browse/WICKET-3019
             Project: Wicket
          Issue Type: Improvement
    Affects Versions: 1.5-M1, 1.4.10, 1.4.9, 1.4.8, 1.4.7, 1.4.6, 1.4.5, 1.4.4, 1.4.3, 1.4.2, 1.4.1
            Reporter: Clint Checketts


Currently when a markup exception occurs it is in the format of:

Component componentId must be applied to a tag of type 'select', not '<span wicket:id="input">' (line 0, column 0)

The error message isn't very helpful when multiple components may have the same ID. This occurs primarily with repeaters.

The change could take place in the Component class in the checkComponentTag/checkComponentTagAttribute method:

findMarkupStream().throwMarkupException(
				"Component " + getId() + " must be applied to a tag of type '" + name + "', not " +
					tag.toUserDebugString()+" "+getPath());



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3019) Add getPath to MarkupExceptions to aid in locatin affected components

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson resolved WICKET-3019.
--------------------------------------

    Resolution: Fixed

Thanks to Peter Ertl for the patches!

> Add getPath to MarkupExceptions to aid in locatin affected components
> ---------------------------------------------------------------------
>
>                 Key: WICKET-3019
>                 URL: https://issues.apache.org/jira/browse/WICKET-3019
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.5-M1
>            Reporter: Clint Checketts
>            Assignee: Jeremy Thomerson
>            Priority: Trivial
>             Fix For: 1.4.11, 1.5-M2
>
>         Attachments: wicket-1.4.patch, wicket-1.5.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Currently when a markup exception occurs it is in the format of:
> Component componentId must be applied to a tag of type 'select', not '<span wicket:id="input">' (line 0, column 0)
> The error message isn't very helpful when multiple components may have the same ID. This occurs primarily with repeaters.
> The change could take place in the Component class in the checkComponentTag/checkComponentTagAttribute method:
> findMarkupStream().throwMarkupException(
> 				"Component " + getId() + " must be applied to a tag of type '" + name + "', not " +
> 					tag.toUserDebugString()+" "+getPath());

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3019) Add getPath to MarkupExceptions to aid in locatin affected components

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903862#action_12903862 ] 

Hudson commented on WICKET-3019:
--------------------------------

Integrated in Apache Wicket 1.4.x #129 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/129/])
    

> Add getPath to MarkupExceptions to aid in locatin affected components
> ---------------------------------------------------------------------
>
>                 Key: WICKET-3019
>                 URL: https://issues.apache.org/jira/browse/WICKET-3019
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.5-M1
>            Reporter: Clint Checketts
>            Assignee: Jeremy Thomerson
>            Priority: Trivial
>             Fix For: 1.4.11, 1.5-M2
>
>         Attachments: wicket-1.4.patch, wicket-1.5.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Currently when a markup exception occurs it is in the format of:
> Component componentId must be applied to a tag of type 'select', not '<span wicket:id="input">' (line 0, column 0)
> The error message isn't very helpful when multiple components may have the same ID. This occurs primarily with repeaters.
> The change could take place in the Component class in the checkComponentTag/checkComponentTagAttribute method:
> findMarkupStream().throwMarkupException(
> 				"Component " + getId() + " must be applied to a tag of type '" + name + "', not " +
> 					tag.toUserDebugString()+" "+getPath());

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3019) Add getPath to MarkupExceptions to aid in locatin affected components

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-3019:
-------------------------------------

         Assignee: Jeremy Thomerson
    Fix Version/s: 1.4.11
                   1.5-M2
         Priority: Trivial  (was: Major)
      Component/s: wicket

> Add getPath to MarkupExceptions to aid in locatin affected components
> ---------------------------------------------------------------------
>
>                 Key: WICKET-3019
>                 URL: https://issues.apache.org/jira/browse/WICKET-3019
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.5-M1
>            Reporter: Clint Checketts
>            Assignee: Jeremy Thomerson
>            Priority: Trivial
>             Fix For: 1.4.11, 1.5-M2
>
>         Attachments: wicket-1.4.patch, wicket-1.5.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Currently when a markup exception occurs it is in the format of:
> Component componentId must be applied to a tag of type 'select', not '<span wicket:id="input">' (line 0, column 0)
> The error message isn't very helpful when multiple components may have the same ID. This occurs primarily with repeaters.
> The change could take place in the Component class in the checkComponentTag/checkComponentTagAttribute method:
> findMarkupStream().throwMarkupException(
> 				"Component " + getId() + " must be applied to a tag of type '" + name + "', not " +
> 					tag.toUserDebugString()+" "+getPath());

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3019) Add getPath to MarkupExceptions to aid in locatin affected components

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3019:
-------------------------------

    Attachment: wicket-1.4.patch
                wicket-1.5.patch

> Add getPath to MarkupExceptions to aid in locatin affected components
> ---------------------------------------------------------------------
>
>                 Key: WICKET-3019
>                 URL: https://issues.apache.org/jira/browse/WICKET-3019
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.5-M1
>            Reporter: Clint Checketts
>         Attachments: wicket-1.4.patch, wicket-1.5.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Currently when a markup exception occurs it is in the format of:
> Component componentId must be applied to a tag of type 'select', not '<span wicket:id="input">' (line 0, column 0)
> The error message isn't very helpful when multiple components may have the same ID. This occurs primarily with repeaters.
> The change could take place in the Component class in the checkComponentTag/checkComponentTagAttribute method:
> findMarkupStream().throwMarkupException(
> 				"Component " + getId() + " must be applied to a tag of type '" + name + "', not " +
> 					tag.toUserDebugString()+" "+getPath());

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.