[GitHub] [hbase] saintstack commented on a change in pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#discussion_r629730178



##########
File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##########
@@ -295,6 +295,11 @@ public void setBackupInfo(BackupInfo backupInfo) {
           .withRootDir(backup.getBackupRootDir()).withTableList(backup.getTableNames())
           .withStartTime(backup.getStartTs()).withCompleteTime(backup.getCompleteTs()).build();
 
+      // Not required if root dir is not same.
+      if (!image.getRootDir().equals(backupInfo.getBackupRootDir())) {

Review comment:
       Maybe add a because here? (I say this because this change looks fine but looking at this and looking at the surrounding code, I'm not clear what is going on -- 'image', 'ancestor' -- and I'm not that inclined to spend much time doing research because as you know, I'm not that mad about the backup feature!). Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org