You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/04/25 22:14:49 UTC
[kudu-CR] Fix table formatting in full data dirs docs
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10211
Change subject: Fix table formatting in full data dirs docs
......................................................................
Fix table formatting in full data dirs docs
Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
---
M docs/administration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/10211/1
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10211
to look at the new patch set (#2).
Change subject: Fix table formatting in full data dirs docs
......................................................................
Fix table formatting in full data dirs docs
Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
---
M docs/administration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/10211/2
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10211/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/10211/1/docs/administration.adoc@828
PS1, Line 828: options="he
> Why not to drop this at all? At least, asciidoctor is able to auto-detect
Done
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Apr 2018 14:47:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Fix table formatting in full data dirs docs
Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Reviewed-on: http://gerrit.cloudera.org:8080/10211
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/administration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Apr 2018 15:29:46 +0000
Gerrit-HasComments: No
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10211/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/10211/1/docs/administration.adoc@828
PS1, Line 828: cols="<,<",
Why not to drop this at all? At least, asciidoctor is able to auto-detect number of columns and render it appropriately.
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 15:03:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 2:
Rendered by GitHub: https://github.com/wdberkeley/kudu/blob/docfix/docs/administration.adoc
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Apr 2018 14:47:34 +0000
Gerrit-HasComments: No
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 2: Verified+1
Unrelated flake in on of tests in TSAN build.
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Apr 2018 15:29:43 +0000
Gerrit-HasComments: No
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:16:49 +0000
Gerrit-HasComments: No
[kudu-CR] Fix table formatting in full data dirs docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 )
Change subject: Fix table formatting in full data dirs docs
......................................................................
Patch Set 1:
The table looks correct now!
I cannot do +2 for Kudu, though.
--
To view, visit http://gerrit.cloudera.org:8080/10211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I098c64c3241e5fc4184b102e10ef619feb7de30a
Gerrit-Change-Number: 10211
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:47:31 +0000
Gerrit-HasComments: No