You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/21 21:31:51 UTC
[GitHub] [airflow] potiuk commented on issue #33596: Apache Pinot provider.yaml references missing PinotHook class
potiuk commented on issue #33596:
URL: https://github.com/apache/airflow/issues/33596#issuecomment-1687072835
> Thoughts on which approach is better / less disruptive to users?
You should add one with "pinot" and the other with "pinot-admin" connection type. Connection type is only really used when you customize UI (i.e. show some fields for extras or change the hint etc. Connection-type allow you to map the type of connection you choose from UI and which field cusomisations should be happening.
Pinot does not define any customisations so it does not matter. But anticipating future, it would make sense to have two different connection types for both.
> I'm not sure that we need to change this values, most of them just for demonstrations. And it quite difficult to keep it updated, because "default" connections sits inside of core, and providers might work on different versions of Airflow, for example now min supported version for providers is 2.4
There is issue to change it https://github.com/apache/airflow/issues/32048 (and it's been followed by Airflow 2.7 changing the commands to create default connections). This is what will be finally moving to providers in 2.8 - similarly as in 2.7 we moved configuration to be part of provider.yaml (or provider_info entrypoint).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org