[GitHub] [accumulo] ctubbsii commented on a change in pull request #2545: Migrate test and hadoop-mapreduce modules to JUnit5

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2545:
URL: https://github.com/apache/accumulo/pull/2545#discussion_r824167367



##########
File path: TESTING.md
##########
@@ -98,7 +98,7 @@ the tests.
 These tests can be run by providing a system property.  Specific ITs can be run using "-Dit.test" or run all tests using:
 
 ```bash
-mvn clean verify -Dtest=foo -Daccumulo.it.properties=/home/user/my_cluster.properties -Dfailsafe.groups=org.apache.accumulo.test.categories.StandaloneCapableClusterTests -Dspotbugs.skip
+mvn clean verify -Dtest=foo -Daccumulo.it.properties=/home/user/my_cluster.properties -Dfailsafe.groups=StandaloneCapableClusterTests -Dspotbugs.skip

Review comment:
       These tag names can be simplified further. The original names like `SunnyDayTests` was chosen because we had to create a class name that made sense on its own. Now that's not necessary, since the class is deleted, and the fact that we're in a "Test" context is already obvious when using the Tag annotation. So, something like `@Tag("SunnyDay")` should suffice instead of `@Tag("SunnyDayTests")`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org