You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/09/19 15:09:24 UTC
[PR] Show column definition in Database perspective, fixes #8464 (hop)
mattcasters opened a new pull request, #8468:
URL: https://github.com/apache/hop/pull/8468
Show database column definition in the Database perspective table and view information dialog, fixes #8464.
### Description
When inspecting information for a table or view in the Database perspective, users can now see the underlying database column definition (e.g. `varchar(100)`, `bigint`, `int identity`, `bool`, `float`, `timestamp(6)`, `numeric(10, 2)`) in column 2, directly following the column name, with the Hop data type shown in column 3 labeled "Hop Type".
Key improvements:
- Added `getDefinition()` and `calculateDefinition(...)` on `DatabaseColumn` formatting database column definitions based on native type name, size, precision, and scale.
- Handled parameterized types (`varchar`, `decimal`, `datetime2`, `timestamp`) while keeping unsized types (`uniqueidentifier`, `money`, `datetime`, `float`, `bigint`, etc.) clean without extraneous dimensions.
- Correctly formats timestamp timezone clauses such as `TIMESTAMP(6) WITH LOCAL TIME ZONE`.
- Handled catalog-first database explorers (e.g. MySQL) by passing catalog appropriately in `DatabaseTableInfoTab.loadColumnDefinitions`.
- Escaped LIKE wildcards (`_`, `%`) when querying database column metadata with `getColumns`.
- Added unit tests in `DatabaseColumnTest` and `DatabaseTableInfoTabTest`.
------------------------
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show column definition in Database perspective, fixes #8464 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters merged PR #8468:
URL: https://github.com/apache/hop/pull/8468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Show column definition in Database perspective, fixes #8464 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #8468:
URL: https://github.com/apache/hop/pull/8468#issuecomment-5750204553
Thanks for the thorough review, @bamaer! All suggested changes have been addressed in the latest commit:
- **Clean `calculateDefinition` signature:** Dropped the unused `sqlType` and `autoIncrement` parameters from `DatabaseColumn.calculateDefinition(...)`, leaving a 4-arg signature `(nativeTypeName, precision, scale, length)`. `autoIncrement` tracking on `DatabaseColumn` and `setOriginalAutoIncrement(...)` in `StandardJdbcTypeMapper` are kept intact.
- **Decimal/Numeric precision:** Removed the arbitrary `<= 38` limit when `scale == 0` within precision 1000, allowing PostgreSQL `numeric(50)` to render as `numeric(50)`.
- **Bit type formatting:** Sized bit types are now formatted properly — bare `bit` is kept when $size \le 1$, and sized `bit(n)` is rendered when $size > 1$ (e.g. MySQL `bit(8)` or PostgreSQL `varbit(16)`).
- **Condition cleanups:**
- Dropped redundant `size < 10000000` condition (`CLOB_LENGTH` is 9,999,999).
- Removed duplicate `DATE` check in branch 1 (already covered by `isUnsizedType`).
- Simplified empty type name fallback in `calculateDefinition(IValueMeta)` to `Const.NVL(valueMeta.getTypeDesc(), "")`.
- Simplified `fillColumns` to read directly from the pre-populated `definitions` map without redundant fallback recalculation.
- **Catalog & Schema scoping in `readColumnDefinitions`:** Added row-level checks on `TABLE_NAME`, `TABLE_CAT`, and `TABLE_SCHEM` from `getColumns()` to prevent cross-schema contamination or collisions when drivers return multi-schema results under null schema patterns.
- **Unit & Integration tests:**
- Added tests in `DatabaseColumnTest` for sized bit types (`bit(8)`, `varbit(16)`) and `numeric(50)`.
- Added integration tests in `DatabaseTableInfoTabTest` driving a table/schema name containing `_` and `%` wildcards through `loadColumnDefinitions`, as well as validating result set filtering on matching table and schema names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org