[jira] [Comment Edited] (KYLIN-2068) Import hive comment when sync tables

["Dong Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562527#comment-15562527 ] 

Dong Li edited comment on KYLIN-2068 at 10/10/16 3:07 PM:
----------------------------------------------------------

Hi Yiming,

I saw a new field(comment) in ColumnDesc. This may cause compatible issue on metadata from old versions.
The old metadata (in json) may not be deserialized due to field missing, and user has to upgrade metadata for this field.

Maybe you can add following annotation to the field, to mark the field as optional.
@JsonInclude(JsonInclude.Include.NON_NULL)
You can find a reference in class org.apache.kylin.cube.model.RowKeyColDesc

Thanks,
Dong


was (Author: lidong_sjtu):
Hi Yiming,

I saw a new field(comment) in ColumnDesc. This may cause compatible issue on metadata from old versions.
The old metadata (in json) may not be deserialized due to field missing, and user must do metadata upgrade for this field.

Maybe you can add following annotation to the field, to mark the field as optional.
@JsonInclude(JsonInclude.Include.NON_NULL)
You can find a reference in class org.apache.kylin.cube.model.RowKeyColDesc

Thanks,
Dong

> Import hive comment when sync tables
> ------------------------------------
>
>                 Key: KYLIN-2068
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2068
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metadata
>            Reporter: Billy(Yiming) Liu
>            Assignee: Billy(Yiming) Liu
>            Priority: Minor
>              Labels: newbie
>         Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, without comment. The "comment" is useful for understanding the column and cube designing. May I propose to include the comment information into column metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)