You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 18:03:42 UTC

[GitHub] [beam] rohdesamuel commented on a change in pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane

rohdesamuel commented on a change in pull request #11777:
URL: https://github.com/apache/beam/pull/11777#discussion_r431341368



##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -1368,7 +1368,7 @@ def _output(
     if timestamp is None:
       # If no watermark hold was set, output at end of window.
       timestamp = window.max_timestamp()
-    elif input_watermark < window.end and self.trigger_fn.has_ontime_pane():
+    elif output_watermark < window.end and self.trigger_fn.has_ontime_pane():

Review comment:
       Yeah this looks good, thanks for thanks for the fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org