You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/22 05:26:02 UTC

[GitHub] [tvm] junrushao1994 commented on a change in pull request #7716: [TensorIR] add TIRTextPrinter support for Block and BlockRealize

junrushao1994 commented on a change in pull request #7716:
URL: https://github.com/apache/tvm/pull/7716#discussion_r598432573



##########
File path: src/printer/tir_text_printer.cc
##########
@@ -217,6 +219,22 @@ Doc TIRTextPrinter::BufferNode2Doc(const BufferNode* buf, Doc doc) {
   return doc << ")";
 }
 
+Doc TIRTextPrinter::PrintBufferRegion(const BufferRegionNode* op) {
+  Doc doc;
+  doc << Print(op->buffer) << "[";
+  for (size_t i = 0; i < op->region.size(); ++i) {
+    if (i != 0) doc << ", ";

Review comment:
       just a nitpick
   
   ```suggestion
       if (i != 0) {
         doc << ", ";
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org