You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Alex Chen (Jira)" <ji...@apache.org> on 2021/12/07 10:05:00 UTC

[jira] [Updated] (BEAM-13393) GroupIntoBatchesTest is failing

     [ https://issues.apache.org/jira/browse/BEAM-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Chen updated BEAM-13393:
-----------------------------
    Description: 
Currently failing a test on core sdk on the following assertion. From the test description, it seems like (totalNumBatches <= numElements && totalNumBatches >= numElements / batchSize) is what is wanted instead, but currently it is testing for numFullBatches instead and is failing the test. Is this intended?

 

Current code:

assertTrue( String.format( "total number of batches should be in the range [%d, %d] but got %d", numElements, numElements / batchSize, numFullBatches), numFullBatches <= numElements && numFullBatches >= numElements / batchSize)

Source:

[https://github.com/apache/beam/blob/v2.34.0/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java#L295]

  was:
Currently failing a test on core sdk on the following assertion. From the test description, it seems like (totalNumBatches <= numElements && totalNumBatches >= numElements / batchSize) is what is wanted instead, but currently it is testing for numElements instead and is failing the test. Is this intended?

 

Current code:

assertTrue( String.format( "total number of batches should be in the range [%d, %d] but got %d", numElements, numElements / batchSize, numFullBatches), numFullBatches <= numElements && numFullBatches >= numElements / batchSize)


Source:

https://github.com/apache/beam/blob/v2.34.0/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java#L295


> GroupIntoBatchesTest is failing
> -------------------------------
>
>                 Key: BEAM-13393
>                 URL: https://issues.apache.org/jira/browse/BEAM-13393
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-core, test-failures
>    Affects Versions: 2.34.0
>            Reporter: Alex Chen
>            Priority: P1
>
> Currently failing a test on core sdk on the following assertion. From the test description, it seems like (totalNumBatches <= numElements && totalNumBatches >= numElements / batchSize) is what is wanted instead, but currently it is testing for numFullBatches instead and is failing the test. Is this intended?
>  
> Current code:
> assertTrue( String.format( "total number of batches should be in the range [%d, %d] but got %d", numElements, numElements / batchSize, numFullBatches), numFullBatches <= numElements && numFullBatches >= numElements / batchSize)
> Source:
> [https://github.com/apache/beam/blob/v2.34.0/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java#L295]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)