You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/26 23:02:55 UTC
Re: Review Request 42738: Included reserved resources in the quota
role sorter for DRF.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 10:02 p.m.)
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 2d01034f43c3653f6233792ee6614fa311249e5c
src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae
Diff: https://reviews.apache.org/r/42738/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 42738: Included reserved resources in the quota
role sorter for DRF.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 11:04 p.m.)
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 2d01034f43c3653f6233792ee6614fa311249e5c
src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae
Diff: https://reviews.apache.org/r/42738/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 42738: Included reserved resources in the quota
role sorter for DRF.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/#review116470
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp (lines 1353 - 1358)
<https://reviews.apache.org/r/42738/#comment177493>
You moved this to the header so we can take it out here.
- Joris Van Remoortere
On Jan. 26, 2016, 10:29 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42738/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 10:29 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 2d01034f43c3653f6233792ee6614fa311249e5c
> src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae
>
> Diff: https://reviews.apache.org/r/42738/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 42738: Included reserved resources in the quota
role sorter for DRF.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 10:29 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Addressed Joris' comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 2d01034f43c3653f6233792ee6614fa311249e5c
src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae
Diff: https://reviews.apache.org/r/42738/diff/
Testing
-------
Thanks,
Michael Park