You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/01/10 22:16:34 UTC

DO NOT REPLY [Bug 118751] New: appearance - color list box too small

https://issues.apache.org/ooo/show_bug.cgi?id=118751

             Bug #: 118751
        Issue Type: DEFECT
           Summary: appearance - color list box too small
    Classification: Application
           Product: Word processor
           Version: OOo 3.4 Beta
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P5
         Component: configuration
        AssignedTo: writerneedsconfirm@openoffice.org
        ReportedBy: drankinatty@suddenlinkmail.com
                CC: ooo-issues@incubator.apache.org


Created attachment 77115
  --> https://issues.apache.org/ooo/attachment.cgi?id=77115
screenshot showing color listboxes that are too small to be navigated
efficiently

AOO 3.4 beta on Arch Linux i686

  The Tools->Options->Appearance color listboxes (dropdowns) are way to small
vertically. They are limited to 4 colors shown out of a very large list that
makes navigation to find the wanted color very difficult. I agree with keeping
the listbox, but the number of visible colors should be increased so the user
sees at least 10. See the attachment for a screenshot of the problem. Thanks.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

--- Comment #13 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #12)
> I saw that you has assigned this bug. That means that once is fixed , you
> will close this bug?

Usually, when the bug has a patch, it is assigned to the developer that will
review the code and commit it.

I reviewed the patch, find it good, committed it, and changed the status to
RESOLVED as FIXED, because it resolved the bug, and it is fixed, on "trunk"
(the code where development for the future release happens).

Now the bug has to be VERIFIED as FIXED, you can do this by downloading a build
from the build bots that has revision number >= 1445663 

Usually, before the release, all VERIFIED bugs are checked once again (because
in the development cycle, it might happen that a fix gets broken by some other
change).

The last step is verifying the fix once a public release has been made. So,
once OpenOffice 4.0 is out, the bug has to be verified, it the fix works, then
the bug is CLOSED as FIXED.

At any time, if the bug is not fixed, it can be REOPENED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

hanya <ha...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80220|0                           |1
        is obsolete|                            |

--- Comment #9 from hanya <ha...@gmail.com> ---
Created attachment 80269
  --> https://issues.apache.org/ooo/attachment.cgi?id=80269&action=edit
Patch to change count of dropdown lines to 10, fixed to be applied to first
listbox also

@Ariel: Thanks for review. I fixed the patch as you said.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Diego Valle Rosado <di...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Diego Valle Rosado <di...@gmail.com> ---
Hi.

This reporte isn't a bug, is like proposal or suggestion to improve the word
processor, ant I submit a email about this suggestion to bugzilla.

Regards,
Diego Valle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Ariel Constenla-Haile <ar...@apache.org> ---
@hanya: thanks for the patch!

Fixed on trunk.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Diego Valle Rosado <di...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Issue Type|DEFECT                      |ENHANCEMENT
         Resolution|INVALID                     |---

--- Comment #2 from Diego Valle Rosado <di...@gmail.com> ---
Change of status

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Rob Weir <ro...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |diegogvallerosado@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Diego Valle Rosado <di...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #3 from Diego Valle Rosado <di...@gmail.com> ---
Change status: confirmed for review and improvement if it's necessary

Diego Valle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

--- Comment #4 from hanya <ha...@gmail.com> ---
Created attachment 80220
  --> https://issues.apache.org/ooo/attachment.cgi?id=80220&action=edit
Patch to change count of dropdown lines to 10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

--- Comment #10 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1445663 into trunk:
i118751 - Increase colour list boxes line count

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |arielch@apache.org
         Issue Type|ENHANCEMENT                 |PATCH
         Resolution|FIXED                       |---
           Assignee|issues@openoffice.apache.or |arielch@apache.org
                   |g                           |

--- Comment #7 from Ariel Constenla-Haile <ar...@apache.org> ---
Reopening.
Assigning to myself to review the patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Diego Valle Rosado <di...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Diego Valle Rosado <di...@gmail.com> ---
This bug was resolved, to change count of dropdown lines to 10.

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

hanya <ha...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hanya.runo@gmail.com

--- Comment #6 from hanya <ha...@gmail.com> ---
The patch was just attached, not applied to trunk yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |AOO 4.0
                 OS|Linux                       |All

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

--- Comment #8 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #4)
> Created attachment 80220 [details]
> Patch to change count of dropdown lines to 10

@hanya: the patch misses the first list box (General - Document background)

The entries are set originally for the first listbox, in the loop they are
copied:


for( sal_Int32 i = 1; i < nCount; i++ )
{
   if(aColorBoxes[i])
   {
    aColorBoxes[i]->CopyEntries( *aColorBoxes[0] );
    if( i < sal_Int32(sizeof(aColorLBHids)/sizeof(aColorLBHids[0])) )
       aColorBoxes[i]->SetHelpId( aColorLBHids[i] );
         aColorBoxes[i]->SetDropDownLineCount( 10 );
   }
}

That's why the index starts are 1, the entries are copied from the first list
box to the other listboxes. Before entering the loop, you should set the count
of drop lines to aColorBoxes[0]

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 118751] appearance - color list box too small

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118751

--- Comment #12 from Diego Valle Rosado <di...@gmail.com> ---
Hi Ariel!

I saw that you has assigned this bug. That means that once is fixed , you will
close this bug?

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.