You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/12/29 08:50:04 UTC

[GitHub] [netbeans] KacerCZ opened a new pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

KacerCZ opened a new pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614


   https://issues.apache.org/jira/browse/NETBEANS-5172
   
   - Enabled and fixed tests for spaces around keyword.
   - Fixed formatting of anonymous functions.
   - Updated expected formatting results in rest of tests.
   
   Sample code:
   ```php
   $lambda = function($param) use($parent) {
       echo "$param\n";
   };
   ```
   
   Formatted after fix:
   ```php
   $lambda = function ($param) use ($parent) {
       echo "$param\n";
   };
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614#issuecomment-752931605


   Configuration is now bound to PHP > Spaces > Other > After Keywords.
   I will add dedicated setting as PHP > Spaces > Before Parentheses > Anonymous Function (there is already setting for Anonymous Class).
   
   By default it will be enabled because it is the way how anonymous functions are formatted in PHP manual - https://www.php.net/manual/en/functions.anonymous.php


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614#issuecomment-752957088


   @KacerCZ Thanks a lot!
   
   @junichi11 Feel free to merge it if it is OK for you. Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614#issuecomment-752938648


   @KacerCZ Great, thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614#issuecomment-752950678


   I added new formatting setting and related tests.
   Also added anonymous function to code sample in options panel.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614#issuecomment-752355525


   Yes, I run all tests in "php.editor.indent" package.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 merged pull request #2614: [NETBEANS-5172] Fix anonymous function formatting

Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #2614:
URL: https://github.com/apache/netbeans/pull/2614


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists