You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2025/05/21 21:16:16 UTC
[PR] [sonataflow-operator] Fix #3151 - Add the `catalog` image on pnpm and adjust platform on bundle [incubator-kie-tools]
ricardozanini opened a new pull request, #3152:
URL: https://github.com/apache/incubator-kie-tools/pull/3152
Fix #3151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Fix #3151 - Add the `catalog` image on pnpm and adjust platform on bundle [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #3152:
URL: https://github.com/apache/incubator-kie-tools/pull/3152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Fix #3151 - Add the `catalog` image on pnpm and adjust platform on bundle [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3152:
URL: https://github.com/apache/incubator-kie-tools/pull/3152#discussion_r2103480054
##########
packages/sonataflow-operator/package.json:
##########
@@ -28,8 +28,11 @@
"image:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make container-build\"",
"image:build:win32": "echo 'Image build not supported on Windows'",
"image:bundle:build": "run-script-os",
- "image:bundle:build:darwin:win32": "echo 'Build Operator bundle image not supported on Windows and macOS'",
- "image:bundle:build:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:win32": "echo 'Build Operator bundle image not supported on Windows'",
+ "image:catalog:build": "run-script-os",
Review Comment:
It's a command that can be called independently. It's not part of the build.
The bundle and catalog images are part of the release process when we have to open PRs for the OperatorHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Fix #3151 - Add the `catalog` image on pnpm and adjust platform on bundle [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3152:
URL: https://github.com/apache/incubator-kie-tools/pull/3152#discussion_r2103108017
##########
packages/sonataflow-operator/package.json:
##########
@@ -28,8 +28,11 @@
"image:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make container-build\"",
"image:build:win32": "echo 'Image build not supported on Windows'",
"image:bundle:build": "run-script-os",
- "image:bundle:build:darwin:win32": "echo 'Build Operator bundle image not supported on Windows and macOS'",
- "image:bundle:build:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:win32": "echo 'Build Operator bundle image not supported on Windows'",
+ "image:catalog:build": "run-script-os",
Review Comment:
Is this being called by `build:dev` or `build:prod`? Or is it just a command to be used during development?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Fix #3151 - Add the `catalog` image on pnpm and adjust platform on bundle [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3152:
URL: https://github.com/apache/incubator-kie-tools/pull/3152#discussion_r2103480291
##########
packages/sonataflow-operator/package.json:
##########
@@ -28,8 +28,11 @@
"image:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make container-build\"",
"image:build:win32": "echo 'Image build not supported on Windows'",
"image:bundle:build": "run-script-os",
- "image:bundle:build:darwin:win32": "echo 'Build Operator bundle image not supported on Windows and macOS'",
- "image:bundle:build:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:win32": "echo 'Build Operator bundle image not supported on Windows'",
+ "image:catalog:build": "run-script-os",
Review Comment:
It also can be used in test environments to test the operator installation.
##########
packages/sonataflow-operator/package.json:
##########
@@ -28,8 +28,11 @@
"image:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make container-build\"",
"image:build:win32": "echo 'Image build not supported on Windows'",
"image:bundle:build": "run-script-os",
- "image:bundle:build:darwin:win32": "echo 'Build Operator bundle image not supported on Windows and macOS'",
- "image:bundle:build:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:darwin:linux": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && run-script-if --bool \"$(build-env containerImages.build)\" --then \"make bundle bundle-build\"",
+ "image:bundle:build:win32": "echo 'Build Operator bundle image not supported on Windows'",
+ "image:catalog:build": "run-script-os",
Review Comment:
It can also be used in test environments to test the operator installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org