You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by olegz <gi...@git.apache.org> on 2016/03/07 16:22:17 UTC
[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/260
NIFI-1595 fixed ReflectionUtils to honor bridge methods
Refactored and simplified ReflectionUtils while at it
Added ReflectionUtilsTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit e887ac52ae948fe4546903aa4442d64f2d6b3113
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date: 2016-03-06T19:46:35Z
NIFI-1595 fixed ReflectionUtils to honor bridge methods
Refactored and simplified ReflectionUtils while at it
Added ReflectionUtilsTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/260#issuecomment-193428093
np, most of the formatting was done to javadocs since they were too long. Is that the changes you are referring to? Just curious
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/260#issuecomment-193430469
Yep. I believe these were valid according to checkstyle rules which permit up to 200 characters/line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/260#issuecomment-193427177
@olegz Code looks good. As seen on the mailing list traffic I was not able to create a similar situation in OS X, but was able to do so within an Ubuntu VM. I took master, applied @pvillard31 proposed PR, built and verified onStopped was not invoked. I then applied this PR and verified that onStopped was invoked. Great job knowing the issue and having a remedy. Will merge into master shortly, but would like to first remove the formatting/whitespace changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/260#issuecomment-193430912
np
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---