You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/01/16 11:18:28 UTC

[GitHub] spark pull request #16339: [SPARK-18917][SQL] Add Skip Partition Check Flag ...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16339#discussion_r96208357
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -445,21 +445,28 @@ case class DataSource(
     
             // If we are appending to a table that already exists, make sure the partitioning matches
             // up.  If we fail to load the table for whatever reason, ignore the check.
    -        if (mode == SaveMode.Append) {
    --- End diff --
    
    shall we just remove this check? it's too expensive. cc @marmbrus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org