You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/01/08 04:14:55 UTC
[PR] Build: Bump roaringbitmap from 1.3.0 to 1.5.3 [iceberg]
manuzhang opened a new pull request, #14991:
URL: https://github.com/apache/iceberg/pull/14991
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3784276831
@ajantha-bhat Agreed. If we are going to use roaringbitmap in the long run, I don't see another way around it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3922208631
as mentioned in the community sync today, maybe we can help with publishing this to maven
https://github.com/RoaringBitmap/RoaringBitmap/issues/749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3896490070
I'm actually less worried about this than anything else coming from jitpack when there are formal releases. For anyone with a corporate repo proxy/security scanner setup it also means involvement with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3892451775
I went to see what binaries were in the roaring bitmap release, but they've only done source releases.
https://github.com/RoaringBitmap/RoaringBitmap/releases/tag/1.6.0
commit is fec1dd5f05c
jitpack says they used the same for their build, and giving a build log it looks no more unsafe than anything else
https://jitpack.io/com/github/RoaringBitmap/RoaringBitmap/1.6.0/build.log
I think it does need a mention in the release notes though: anyone pulling iceberg core through maven/gradle/sbt will get an error unless they work out where the artifact came from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#discussion_r2691181279
##########
spark/v4.1/build.gradle:
##########
@@ -277,7 +277,9 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
}
integrationImplementation "org.scala-lang.modules:scala-collection-compat_${scalaVersion}:${libs.versions.scala.collection.compat.get()}"
- integrationImplementation "org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}"
+ integrationImplementation ("org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}") {
+ exclude group: 'org.roaringbitmap'
+ }
Review Comment:
That makes sense, though is this not an issue also for the other spark versions? Did something get changed specifically within 4.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3892921789
Hey @steveloughran I agree, in fact I mean to start a dev list thread on this to make sure it doesn't fly under the radar. I think the upgrade is unavoidable but downstream consumers should be aware of the implications for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#discussion_r2690941757
##########
spark/v4.1/build.gradle:
##########
@@ -277,7 +277,9 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
}
integrationImplementation "org.scala-lang.modules:scala-collection-compat_${scalaVersion}:${libs.versions.scala.collection.compat.get()}"
- integrationImplementation "org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}"
+ integrationImplementation ("org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}") {
+ exclude group: 'org.roaringbitmap'
+ }
Review Comment:
Is this exclusion strictly required? Or are we just trying to slim down the spark-hive test dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #14991:
URL: https://github.com/apache/iceberg/pull/14991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3922326194
I think the main thing as discussed in the sync is we will want to revert this for 1.11 since it should only be neccessary when we do a spark 4.2 (or any other integration) that uses the upgraded dependency; so it's preferrable to defer this until we really need this. Don't get me wrong, it's inevitable to have to address this issue, just think we should minimize the pain when folks when to upgrade to 1.11 since it's not really neccessary right now (as far as I can tell).
Long term we should work with the RoaringBitmap folks to update to maven central as @kevinjqliu said or there's some alternatives like shading (which I'd really strongly prefer to avoid shading more stuff into iceberg core).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#discussion_r2672144227
##########
spark/v4.0/build.gradle:
##########
@@ -324,7 +324,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra', 'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap', 'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is `com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java package name for RoaringBitmap remains `org.roaringbitmap`. The relocate directive should use the Java package name, not the Maven coordinate. This should be `relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
```
##########
spark/v3.5/build.gradle:
##########
@@ -315,7 +315,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra', 'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap', 'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is `com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java package name for RoaringBitmap remains `org.roaringbitmap`. The relocate directive should use the Java package name, not the Maven coordinate. This should be `relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
```
##########
spark/v4.1/build.gradle:
##########
@@ -334,7 +336,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra', 'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap', 'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is `com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java package name for RoaringBitmap remains `org.roaringbitmap`. The relocate directive should use the Java package name, not the Maven coordinate. This should be `relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
```
##########
spark/v3.4/build.gradle:
##########
@@ -313,7 +313,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra', 'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap', 'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is `com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java package name for RoaringBitmap remains `org.roaringbitmap`. The relocate directive should use the Java package name, not the Maven coordinate. This should be `relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#discussion_r2691081479
##########
spark/v4.1/build.gradle:
##########
@@ -277,7 +277,9 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
}
integrationImplementation "org.scala-lang.modules:scala-collection-compat_${scalaVersion}:${libs.versions.scala.collection.compat.get()}"
- integrationImplementation "org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}"
+ integrationImplementation ("org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}") {
+ exclude group: 'org.roaringbitmap'
+ }
Review Comment:
Otherwise, there will be two versions of Roaringbitmap on the test classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3881658484
> Are these the official roaring bitmap artifacts, just served up to java build tools?
I suppose. I followed the [changes in Spark](https://github.com/apache/spark/pull/54232).
It looks having been [used in a bunch of Apache projects](https://github.com/search?q=%22jitpack.io%22+org%3Aapache&type=code&p=2) besides Iceberg and Polaris.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3736635344
@amogh-jahagirdar Updated LICENSE files. BTW, do you know why the LICENSE file in Filnk doesn't have version with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3770510989
@amogh-jahagirdar @kevinjqliu any more comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3879708196
This is going to break anyone who pulls in unshaded iceberg artifacts until they add that new repo.
```
[ERROR] dependency: com.github.RoaringBitmap.RoaringBitmap:roaringbitmap:jar:1.6.0 (test)
[ERROR] com.github.RoaringBitmap.RoaringBitmap:roaringbitmap:jar:1.6.0 was not found in https://repository.jboss.org/nexus/content/groups/public/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of repository.jboss.org has elapsed or updates are forced
[ERROR] com.github.RoaringBitmap.RoaringBitmap:roaringbitmap:jar:1.6.0 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced
[ERROR]
```
What worries me is not less the change than the risk that jitpack isn't really a formal release process, more "jitpack finds and builds the right artifact when asked"
Are these the official roaring bitmap artifacts, just served up to java build tools?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3891184355
@manuzhang thanks. I will make sure the checksums are the same. I do note jitpack say "list us last", which means they'd prefer artifacts to come via other repos, where the authors can and should sign their artifacts, before going to jitpack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3770806489
Thanks @manuzhang and thanks @amogh-jahagirdar for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#issuecomment-3783679445
This PR affects the Iceberg downstream projects too.
Example: https://github.com/apache/polaris/pull/3504
I see that other projects that uses roaringbitmap (like Apache Spark) done the same thing
https://github.com/apache/spark/pull/52892
But Spark community has observed that jitpack has some occasional downtime and their CI is flaky because of that sometimes. (Discussed in the the above PR linked).
I see two issues:
a) Forcing downstream users to add jitpack dependency (maybe some organizations have restrictions)
b) jitpack made Spark CI flaky a bit.
But If Iceberg has to support Spark 4.2 release, I understand that we need to add jitpack dependencies too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Bump roaringbitmap from 1.3.0 to 1.6.0 [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#discussion_r2691225954
##########
spark/v4.1/build.gradle:
##########
@@ -277,7 +277,9 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
}
integrationImplementation "org.scala-lang.modules:scala-collection-compat_${scalaVersion}:${libs.versions.scala.collection.compat.get()}"
- integrationImplementation "org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}"
+ integrationImplementation ("org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}") {
+ exclude group: 'org.roaringbitmap'
+ }
Review Comment:
Nice catch! I forgot to update for other Spark versions as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org