You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/07/21 16:01:01 UTC
[GitHub] incubator-brooklyn pull request: DynamicFabric: existing children ...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/82
DynamicFabric: existing children as members; and EntitySpec.members/groups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/DynamicFabric-existing-children-as-members
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit fede9621588ddf2a60cb58015db4cc00ab60deaa
Author: Aled Sage <al...@gmail.com>
Date: 2014-07-21T13:21:30Z
Improve DynamicFabric test coverage
- for when fabric has existing children
commit 35f267fe7c4a21d4afefc68a5f97caca1e04dfba
Author: Aled Sage <al...@gmail.com>
Date: 2014-07-21T13:31:23Z
DynamicFabric: add existing children as members
commit 406702291832cc21b9cc820d5d78920933f8233d
Author: Aled Sage <al...@gmail.com>
Date: 2014-07-21T13:48:07Z
Adds EntitySpec.groups and EntitySpec.members
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: DynamicFabric: existing children ...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/82#issuecomment-50465369
@aledsage I'll ping ASFinfra
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: DynamicFabric: existing children ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/82#issuecomment-50465008
@richardcloudsoft @grkvlt any idea what is happening here?
https://git-wip-us.apache.org/repos/asf?p=incubator-brooklyn.git shows PR #82 as merged, but https://github.com/apache/incubator-brooklyn/commits is still behind (i.e. doesn't include that, or the merging of #98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: DynamicFabric: existing children ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/82#issuecomment-50344345
Reviewed by @Nakomis who has also built https://github.com/apache/incubator-brooklyn/pull/88 on top.
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: DynamicFabric: existing children ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---