You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "yf13 (via GitHub)" <gi...@apache.org> on 2024/05/03 05:22:22 UTC

Re: [PR] video/fb: userspace framebuffer support [nuttx]

yf13 commented on code in PR #12238:
URL: https://github.com/apache/nuttx/pull/12238#discussion_r1588744223


##########
drivers/video/fb.c:
##########
@@ -1032,7 +1032,13 @@ static int fb_mmap(FAR struct file *filep, FAR struct mm_map_entry_s *map)
   if (map->offset >= 0 && map->offset < panelinfo.fblen &&
       map->length && map->offset + map->length <= panelinfo.fblen)
     {
+#ifdef CONFIG_BUILD_KERNEL
+      map->vaddr = vm_map_region((uintptr_t)panelinfo.fbmem,
+                                            panelinfo.fblen);
+      map->vaddr += map->offset;

Review Comment:
   rolled back to confirm  CI status...  just pushed an update supporting unaligned paddr mapping and moved `vm_map_xxx()` into ` vm_region.c`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org