[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager
URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r314498722
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppenderatorsManager.java
 ##########
 @@ -248,6 +289,50 @@ private AppenderatorConfig rewriteAppenderatorConfigMemoryLimits(AppenderatorCon
     return new MemoryParameterOverridingAppenderatorConfig(baseConfig, perWorkerLimit);
   }
 
+  private class DatasourceBundle
+  {
+    private final SinkQuerySegmentWalker walker;
+    private final Map<String, List<Appenderator>> taskAppenderatorMap;
+
+    public DatasourceBundle(
+        String dataSource
+    )
+    {
+      this.taskAppenderatorMap = new HashMap<>();
+
+      VersionedIntervalTimeline<String, Sink> sinkTimeline = new VersionedIntervalTimeline<>(
+          String.CASE_INSENSITIVE_ORDER
 
 Review comment:
   Hmm, I'm not sure what is the proper comparator for the timeline. Raised https://github.com/apache/incubator-druid/issues/8320.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org