You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/07/10 09:09:58 UTC
[GitHub] carbondata pull request #2472: [CARBONDATA-2717] fixed table id empty proble...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2472
[CARBONDATA-2717] fixed table id empty problem while taking drop lock
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata table_identfifier_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2472
----
commit 25ca99908cd22b46cf295867d61c1f2c18c09249
Author: kunal642 <ku...@...>
Date: 2018-07-10T09:08:05Z
fixed table id empty problem while taking drop lock
----
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2472
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5766/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5760/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6980/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5795/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2472
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5745/
---
[GitHub] carbondata pull request #2472: [CARBONDATA-2717] fixed table id empty proble...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2472
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2472
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5770/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6992/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7027/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5792/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7014/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7019/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7036/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5771/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2472
LGTM
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2472
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5777/
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5815/
---
[GitHub] carbondata pull request #2472: [CARBONDATA-2717] fixed table id empty proble...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2472#discussion_r201610274
--- Diff: core/src/main/java/org/apache/carbondata/core/locks/CarbonLockUtil.java ---
@@ -121,8 +124,11 @@ public static void deleteExpiredSegmentLockFiles(CarbonTable carbonTable) {
final long segmentLockFilesPreservTime =
CarbonProperties.getInstance().getSegmentLockFilesPreserveHours();
AbsoluteTableIdentifier absoluteTableIdentifier = carbonTable.getAbsoluteTableIdentifier();
- String lockFilesDir = CarbonTablePath
- .getLockFilesDirPath(absoluteTableIdentifier.getTablePath());
+ String lockFilesDir = CarbonProperties.getInstance()
+ .getProperty(CarbonCommonConstants.LOCK_PATH, "");
+ if (StringUtils.isEmpty(lockFilesDir)) {
+ lockFilesDir = CarbonTablePath.getLockFilesDirPath(absoluteTableIdentifier.getTablePath());
+ }
--- End diff --
getLockPath from CarbonLockFactory is configurable lock is specified
---
[GitHub] carbondata issue #2472: [CARBONDATA-2717] fixed table id empty problem while...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2472
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5867/
---