You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/12/27 00:18:04 UTC
[Impala-ASF-CR] Use Status::Expected for missing Char codegen.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12128
Change subject: Use Status::Expected for missing Char codegen.
......................................................................
Use Status::Expected for missing Char codegen.
There is no mystery as to how this error message happens, so
we can reduce log file sizes (mostly in tests) by stripping
away the stack trace.
Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
---
M be/src/exec/text-converter.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/12128/1
--
To view, visit http://gerrit.cloudera.org:8080/12128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Use Status::Expected for missing Char codegen.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12128 )
Change subject: Use Status::Expected for missing Char codegen.
......................................................................
Use Status::Expected for missing Char codegen.
There is no mystery as to how this error message happens, so
we can reduce log file sizes (mostly in tests) by stripping
away the stack trace.
Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Reviewed-on: http://gerrit.cloudera.org:8080/12128
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/text-converter.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Use Status::Expected for missing Char codegen.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12128 )
Change subject: Use Status::Expected for missing Char codegen.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3603/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Dec 2018 17:58:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Use Status::Expected for missing Char codegen.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12128 )
Change subject: Use Status::Expected for missing Char codegen.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Dec 2018 15:48:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Use Status::Expected for missing Char codegen.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12128 )
Change subject: Use Status::Expected for missing Char codegen.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1673/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Dec 2018 01:00:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Use Status::Expected for missing Char codegen.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12128 )
Change subject: Use Status::Expected for missing Char codegen.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1651872ac608aa030ff2cca9cde186ec8a5c7cc2
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Dec 2018 21:48:30 +0000
Gerrit-HasComments: No