[GitHub] [zookeeper] Randgalt commented on a change in pull request #1010: ZOOKEEPER-3425:ttl node should not have the children and ranking the ttl by expireTime asc for the performance

[GitBox <gi...@apache.org>]

Randgalt commented on a change in pull request #1010: ZOOKEEPER-3425:ttl node should not have the children and ranking the ttl by expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#discussion_r347412239
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ContainerManager.java
 ##########
 @@ -169,7 +175,6 @@ protected long getMinIntervalMs() {
 
     // VisibleForTesting
     protected long getElapsed(DataNode node) {
-        return Time.currentWallTime() - node.stat.getMtime();
+        return Time.currentWallTime() - node.stat.getCtime();
 
 Review comment:
   This is a breaking change and is incorrect. The concept of a TTL node is that it expires after non-use. If the TTL is continually updated it should not be deleted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services