You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2014/11/06 14:23:57 UTC
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
GitHub user grkvlt opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/305
Couchbase changes for Clocker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/incubator-brooklyn fix/couchbase-clocker
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #305
----
commit 0c337f9ddc214fc1dade3fc53afa0c5aba75fe08
Author: Andrew Kennedy <gr...@apache.org>
Date: 2014-11-04T21:12:45Z
Couchbase changes for Clocker
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/305#issuecomment-62023925
Exception reported by @andreaturli
```
Caused by: java.lang.RuntimeException: Error running iptables update for TCP/49166 on SshMachineLocation[37.58.100.228:37.58.100.228/37.58.100.228]
at brooklyn.location.docker.DockerContainerLocation.addIptablesRule(DockerContainerLocation.java:113)
at brooklyn.location.docker.DockerContainerLocation.obtainPort(DockerContainerLocation.java:144)
at brooklyn.event.basic.PortAttributeSensorAndConfigKey.convertConfigToSensor(PortAttributeSensorAndConfigKey.java:99)
at brooklyn.event.basic.PortAttributeSensorAndConfigKey.convertConfigToSensor(PortAttributeSensorAndConfigKey.java:1)
at brooklyn.event.basic.AttributeSensorAndConfigKey.getAsSensorValue(AttributeSensorAndConfigKey.java:111)
... 12 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/305#discussion_r19999247
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeImpl.java ---
@@ -85,19 +89,19 @@ public CouchbaseNodeDriver getDriver() {
@Override
public void init() {
super.init();
-
+
subscribe(this, Attributes.SERVICE_UP, new SensorEventListener<Boolean>() {
@Override
public void onEvent(SensorEvent<Boolean> booleanSensorEvent) {
if (Boolean.TRUE.equals(booleanSensorEvent.getValue())) {
Integer webPort = getAttribute(CouchbaseNode.COUCHBASE_WEB_ADMIN_PORT);
- Preconditions.checkNotNull(webPort, CouchbaseNode.COUCHBASE_WEB_ADMIN_PORT+" not set for %s; is an acceptable port available?", this);
+ Preconditions.checkNotNull(webPort, "Web admin port not set for %s; is an acceptable port available?", this);
--- End diff --
why this? if you don't like the constant's verbose toString you can do `.getName()` -- I think that would be better as it says exactly which config key is relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/305#issuecomment-61977777
WIP for @andreaturli to review, do not merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/305#discussion_r19999286
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeSshDriver.java ---
@@ -214,17 +201,15 @@ public String getVersion() {
@Override
public String getOsTag() {
- return newDownloadLinkSegmentComputer().getOsTag();
+ return newDownloadLinkSegmentComputer().getOsTag();
}
-
+
protected DownloadLinkSegmentComputer newDownloadLinkSegmentComputer() {
- return new DownloadLinkSegmentComputer(getLocation().getOsDetails(), !isPreV3(), ""+getEntity());
+ return new DownloadLinkSegmentComputer(getLocation().getOsDetails(), !isPreV3(), getEntity().toString());
--- End diff --
`Strings.toString(getEntity())` in case null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/305#issuecomment-62715821
Replaced by #317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---