[GitHub] [iceberg] openinx commented on a change in pull request #2364: Spark: Add an action to rewrite equality deletes

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2364:
URL: https://github.com/apache/iceberg/pull/2364#discussion_r600258260



##########
File path: api/src/main/java/org/apache/iceberg/RewriteFiles.java
##########
@@ -42,4 +42,13 @@
    * @return this for method chaining
    */
   RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile> filesToAdd);
+
+  /**
+   * Add a rewrite that replaces one set of deletes with another that contains the same deleted rows.
+   *
+   * @param deletesToDelete files that will be replaced, cannot be null or empty.
+   * @param deletesToAdd files that will be added, cannot be null or empty.
+   * @return this for method chaining
+   */
+  RewriteFiles rewriteDeletes(Set<DeleteFile> deletesToDelete, Set<DeleteFile> deletesToAdd);

Review comment:
       Before we get this PR merged,  we must merge this PR first (https://github.com/apache/iceberg/pull/2294).  Because PR 2294 has extended the API `RewriteFiles` to accept both data files & delete files.  This PR is trying to convert equality-deletions to pos-deletions , which is actually a special case of the PR 2294.  After we merged PR 2294,  we could rebase this PR. 
   
   For getting https://github.com/apache/iceberg/pull/2294 merged,  I need a committer to review it. FYI @rdblue , @yyanyy .
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org