You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by granders <gi...@git.apache.org> on 2016/01/22 01:16:05 UTC
[GitHub] kafka pull request: MINOR: vagrant aws overrideable ec2 instance n...
GitHub user granders opened a pull request:
https://github.com/apache/kafka/pull/801
MINOR: vagrant aws overrideable ec2 instance name prefix
@ewencp
This small change allows users to use Vagrantfile.local to specify a custom prefix for names of ec2 instances brought up with vagrant.
This makes management of multiple aws test clusters a little easier since individual clusters can be assigned different name prefixes.
if `ec2_instance_name_prefix` is not specified in `Vagrantfile.local`, behavior will be exactly the same as before this change.
Testing:
- aws: I verified worker nodes, broker nodes, zk nodes with and without the prefix override. Behavior is as expected
- locally: I verified that bringing up worker nodes, broker nodes, zk nodes on a local machine is not impacted by this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/confluentinc/kafka minor-vagrant-aws-overrideable-prefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/801.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #801
----
commit 761a8a04c26a26120e6943d3204ce861daf1cfbb
Author: Geoff Anderson <ge...@confluent.io>
Date: 2016-01-21T23:35:32Z
Made it possible to use Vagrantfile.local to override the prefix for ec2 instance names on ducktape slave machines
commit 40c6e29e0d245655efd40f1fd8cf2b76721355c9
Author: Geoff Anderson <ge...@confluent.io>
Date: 2016-01-21T23:49:12Z
Fixed scoping problem
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request: MINOR: vagrant aws overrideable ec2 instance n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/801
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---