You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2016/07/18 06:57:10 UTC
[GitHub] couchdb pull request #434: Clean up ./dev/run output
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb/pull/434
Clean up ./dev/run output
If connection succeeds eventually, don't report spurious error when retrying.
Turns `./dev/run` output from this:
```
[ * ] Check node at http://127.0.0.1:15984/ ... failed: [Errno socket error] [Errno 111] Connection refused
[ * ] Check node at http://127.0.0.1:25984/ ... ok
[ * ] Check node at http://127.0.0.1:35984/ ... ok
[ * ] Check node at http://127.0.0.1:15984/ ... ok
```
to this:
```
[ * ] Check node at http://127.0.0.1:15984/ ... ok
[ * ] Check node at http://127.0.0.1:25984/ ... ok
[ * ] Check node at http://127.0.0.1:35984/ ... ok
```
Cleaner and a bit less scary for new developers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb clean-dev-run-startup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/434.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #434
----
commit 99935555518547c2a984388792149697a9be05d2
Author: Nick Vatamaniuc <va...@gmail.com>
Date: 2016-07-18T06:33:41Z
Clean up ./dev/run output
If connection succeeds eventually, don't report spurious error when retrying.
Turns `./dev/run` output from this:
```
[ * ] Check node at http://127.0.0.1:15984/ ... failed: [Errno socket error] [Errno 111] Connection refused
[ * ] Check node at http://127.0.0.1:25984/ ... ok
[ * ] Check node at http://127.0.0.1:35984/ ... ok
[ * ] Check node at http://127.0.0.1:15984/ ... ok
```
to this:
```
[ * ] Check node at http://127.0.0.1:15984/ ... ok
[ * ] Check node at http://127.0.0.1:25984/ ... ok
[ * ] Check node at http://127.0.0.1:35984/ ... ok
```
Cleaner and a bit less scary for new developers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb issue #434: Clean up ./dev/run output
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:
https://github.com/apache/couchdb/pull/434
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request #434: Clean up ./dev/run output
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/434#discussion_r71105493
--- Diff: dev/run ---
@@ -355,6 +355,7 @@ def check_node_alive(url):
try:
with contextlib.closing(urlopen(url)):
pass
+ error = None
--- End diff --
Logically, it should be in `else` block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request #434: Clean up ./dev/run output
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/434#discussion_r71106030
--- Diff: dev/run ---
@@ -355,6 +355,7 @@ def check_node_alive(url):
try:
with contextlib.closing(urlopen(url)):
pass
+ error = None
--- End diff --
Agree, good point. Will move it to else block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request #434: Clean up ./dev/run output
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb/pull/434
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---