[GitHub] [beam] kw2542 edited a comment on pull request #14942: [BEAM-8137] Add Main method to ExternalWorkerService

[GitBox <gi...@apache.org>]

kw2542 edited a comment on pull request #14942:
URL: https://github.com/apache/beam/pull/14942#issuecomment-857252173


   > Can you fix this? (It may be best to just move the `main(environmentVarGetter)` method body into the regular `main(args)`, I don't think we really need two separate methods.)
   > 
   > ```
   > > Task :runners:portability:java:compileJava
   > /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/runners/portability/java/src/main/java/org/apache/beam/runners/portability/ExternalWorkerService.java:134: error: [methodref.return.invalid] Incompatible return type
   >     main(System::getenv);
   >          ^
   >   found   : @Initialized @Nullable String
   >   required: @Initialized @NonNull String
   >   Consequence: method
   >     @Initialized @Nullable String getenv(@Initialized @NonNull String p0) in java.lang.System
   >   is not a valid method reference for
   >     @Initialized @NonNull String apply(@Initialized @NonNull Function<@Initialized @NonNull String, @Initialized @NonNull String> this, @Initialized @NonNull String p0) in java.util.function.Function
   > 1 error
   > ```
   
   Sure. Could you help me point to where did you find this error? 
   
   The failed "Java ("Run Java PreCommit")" task seems to be failing on flaky `ElasticsearchIOTest` and I could not find the above error. I am wondering if I missed anything when looking at test results.
   
   In addition, when I run 
   ```
   $ ./gradlew :runners:portability:java:compileJava
   ```
   
   locally, I could not find the error either


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org