[jira] Commented: (HARMONY-1651) [drlvm][kernel] Some issues in j.l.Package implementation

["Alexey Varlamov (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-1651?page=comments#action_12439396 ] 
            
Alexey Varlamov commented on HARMONY-1651:
------------------------------------------

Serguei, thanks for the patches. Some observations below:
1) Please try to incorporate the testcases to exisiting test suites of classlib and submit corresponding patches, instead of standalone tests.
2) Fix for isCompatibleWith() seems incorrect: any of 2 calls to StringTokenizer() constructors with null string would cause NPE, while seemingly no reason for NPE in the cycle itself.
3) Issue #3 duplicates HARMONY-813, which basically provides the same fix but adds a testcase.

> [drlvm][kernel] Some issues in j.l.Package implementation
> ---------------------------------------------------------
>
>                 Key: HARMONY-1651
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1651
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Serguei Zapreyev
>         Attachments: H1651.jlP_impl.patch, Test1.java, Test2.java, Test3.java
>
>
> Some defects in Package impl: 
> - Package.isCompatibleWith("") throws NPE instead of NumberFormatException (Teast1). 
>   Throwing the NumberFormatException as demanded resolves the issue. 
> - java.lang.Package.isSealed((java.net.URL)null) should throw NPE (Teast2). 
>   Throwing the NulPointerException as demanded resolves the issue. 
> - pakage info inaccessibility (DRLVM does not provide access to information describing a package.)   
>   (Teast3). 
>   Changing the dot-separated Manifest entry name form to slash-separated one resolves the issue.
> I'm going to attach the corresponding patch to fix the issues and the corresponding tests.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira