You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/06 02:51:47 UTC
Review Request: Fixed Duration to use a base unit of seconds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9765/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See MESOS-335.
This addresses bug MESOS-335.
https://issues.apache.org/jira/browse/MESOS-335
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/duration.hpp 17d2d316fcd994212f41577f54c112e41e061bc6
Diff: https://reviews.apache.org/r/9765/diff/
Testing
-------
sudo make check -j GTEST_FILTER="Statistics.*" GTEST_REPEAT=10000
Thanks,
Ben Mahler
Re: Review Request: Fixed Duration to use a base unit of seconds.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9765/#review17851
-----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/duration.hpp
<https://reviews.apache.org/r/9765/#comment37811>
But you didn't fix this! ;)
- Benjamin Hindman
On March 14, 2013, 1:55 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9765/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 1:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-335.
>
>
> This addresses bug MESOS-335.
> https://issues.apache.org/jira/browse/MESOS-335
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/duration.hpp 2904cf4abb408173b11d0818e13d2f70ecfbc1fa
>
> Diff: https://reviews.apache.org/r/9765/diff/
>
>
> Testing
> -------
>
> sudo make check -j GTEST_FILTER="Statistics.*" GTEST_REPEAT=10000
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed Duration to use a base unit of seconds.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9765/#review17889
-----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/duration.hpp
<https://reviews.apache.org/r/9765/#comment37868>
I forgot since we didn't comment on the review =/
- Ben Mahler
On March 14, 2013, 1:55 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9765/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 1:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-335.
>
>
> This addresses bug MESOS-335.
> https://issues.apache.org/jira/browse/MESOS-335
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/duration.hpp 2904cf4abb408173b11d0818e13d2f70ecfbc1fa
>
> Diff: https://reviews.apache.org/r/9765/diff/
>
>
> Testing
> -------
>
> sudo make check -j GTEST_FILTER="Statistics.*" GTEST_REPEAT=10000
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed Duration to use a base unit of seconds.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9765/
-----------------------------------------------------------
(Updated March 14, 2013, 1:55 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased, no need for review.
Description
-------
See MESOS-335.
This addresses bug MESOS-335.
https://issues.apache.org/jira/browse/MESOS-335
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/duration.hpp 2904cf4abb408173b11d0818e13d2f70ecfbc1fa
Diff: https://reviews.apache.org/r/9765/diff/
Testing
-------
sudo make check -j GTEST_FILTER="Statistics.*" GTEST_REPEAT=10000
Thanks,
Ben Mahler
Re: Review Request: Fixed Duration to use a base unit of seconds.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9765/#review17624
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 6, 2013, 1:51 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9765/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 1:51 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-335.
>
>
> This addresses bug MESOS-335.
> https://issues.apache.org/jira/browse/MESOS-335
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/duration.hpp 17d2d316fcd994212f41577f54c112e41e061bc6
>
> Diff: https://reviews.apache.org/r/9765/diff/
>
>
> Testing
> -------
>
> sudo make check -j GTEST_FILTER="Statistics.*" GTEST_REPEAT=10000
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed Duration to use a base unit of seconds.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9765/#review17443
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 6, 2013, 1:51 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9765/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 1:51 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-335.
>
>
> This addresses bug MESOS-335.
> https://issues.apache.org/jira/browse/MESOS-335
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/duration.hpp 17d2d316fcd994212f41577f54c112e41e061bc6
>
> Diff: https://reviews.apache.org/r/9765/diff/
>
>
> Testing
> -------
>
> sudo make check -j GTEST_FILTER="Statistics.*" GTEST_REPEAT=10000
>
>
> Thanks,
>
> Ben Mahler
>
>