You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ph...@apache.org on 2018/02/02 18:51:41 UTC

[17/19] impala git commit: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

When fetching explain output from HS2 using Impyla, rows come back in
lists of 1-tuples.

This patch exhibits the need to do end-to-end testing when the case
warrants. In this case, although the unit test for
http://gerrit.cloudera.org:8080/9141 passes, I neglected to make sure
this worked in the stress test. Mea culpa. It works now.

Change-Id: Id26d1db15c22a971dc1a346ad6d1df758306c3c5
Reviewed-on: http://gerrit.cloudera.org:8080/9146
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/0f910a8b
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/0f910a8b
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/0f910a8b

Branch: refs/heads/2.x
Commit: 0f910a8b2938ae3f05ca93667ede06129a49cd99
Parents: 8b5f133
Author: Michael Brown <mi...@cloudera.com>
Authored: Fri Jan 26 10:22:03 2018 -0800
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Feb 2 01:10:16 2018 +0000

----------------------------------------------------------------------
 tests/stress/concurrent_select.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/0f910a8b/tests/stress/concurrent_select.py
----------------------------------------------------------------------
diff --git a/tests/stress/concurrent_select.py b/tests/stress/concurrent_select.py
index 86e8978..e03c8b2 100755
--- a/tests/stress/concurrent_select.py
+++ b/tests/stress/concurrent_select.py
@@ -1384,7 +1384,8 @@ def estimate_query_mem_mb_usage(query, query_runner):
       return
     LOG.debug("Explaining query\n%s", query.sql)
     cursor.execute('EXPLAIN ' + query.sql)
-    explain_lines = cursor.fetchall()
+    explain_rows = cursor.fetchall()
+    explain_lines = [row[0] for row in explain_rows]
     mem_limit, units = match_memory_estimate(explain_lines)
     return parse_mem_to_mb(mem_limit, units)