Re: cvs commit: xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql XSPSQLLibrary.java

[Mark Washeim <es...@canuck.com>]

on 22/6/00 9:49 pm, balld@locus.apache.org at balld@locus.apache.org wrote:

> balld       00/06/22 12:49:20
> 
> Modified:    src/org/apache/cocoon/processor/xsp/library/sql
> XSPSQLLibrary.java
> Log:
> update-rows-attribute is no longer mandatory for updates
> 
> Revision  Changes    Path
> 1.8       +2 -2  
> xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql/XSPSQLLibrary.java
> 
> Index: XSPSQLLibrary.java
> ===================================================================
> RCS file: 
> /home/cvs/xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql/XSPSQLLib
> rary.java,v
> retrieving revision 1.7
> retrieving revision 1.8
> diff -u -r1.7 -r1.8
> --- XSPSQLLibrary.java 2000/05/16 20:01:06 1.7
> +++ XSPSQLLibrary.java 2000/06/22 19:49:18 1.8
> @@ -60,7 +60,7 @@
> * A processor that performs SQL database queries.
> *
> * @author <a href="mailto:balld@webslingerZ.com">Donald Ball</a>
> - * @version $Revision: 1.7 $ $Date: 2000/05/16 20:01:06 $
> + * @version $Revision: 1.8 $ $Date: 2000/06/22 19:49:18 $
> */
> 
> public class XSPSQLLibrary {
> @@ -143,7 +143,7 @@
> if (!st.execute(query)) {
> /** this returns the number of rows we updated, or -1 on error **/
> int update_rows = st.getUpdateCount();
> -            if (results_element != null) {
> +            if (results_element != null && !"".equals(update_rows_attribute))
> {
> results_element.setAttribute(update_rows_attribute,""+update_rows);
> }
> } else {
> 
> 
> 
> 
> ----------------------------------------------------------------------
> In case of troubles, e-mail:     webmaster@xml.apache.org
> To unsubscribe, e-mail:          cocoon-cvs-unsubscribe@xml.apache.org
> For additional commands, e-mail: cocoon-cvs-help@xml.apache.org
> 

Thanks!

Though, it actually makes a great deal of sense. Namely, unless you're
planning on executing the sql 'manually', you need something in the response
that 'tersely' expresses sucess. Or so I'm lead to believe in playing with
this... thanks for you work on it, it's GREAT!



-- 
Mark (Poetaster) Washeim

'On the linen wrappings of certain mummified remains
found near the Etrurian coast are invaluable writings
that await translation.

Quem colorem habet sapientia?'

Evan S. Connell

 

Re: cvs commit: xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql XSPSQLLibrary.java

[Mark Washeim <es...@canuck.com>]

on 23/6/00 12:02 am, Donald Ball at balld@webslingerZ.com wrote:

> On Thu, 22 Jun 2000, Mark Washeim wrote:
> 
>> Though, it actually makes a great deal of sense. Namely, unless you're
>> planning on executing the sql 'manually', you need something in the response
>> that 'tersely' expresses sucess. Or so I'm lead to believe in playing with
>> this... thanks for you work on it, it's GREAT!
> 
> sure, but i reckon it's better to succeed silently than to fail with a
> confusing error message.
> 
> - donald
> 

+1 to that. And thanks very kindly.

-- 
Mark (Poetaster) Washeim

'On the linen wrappings of certain mummified remains
found near the Etrurian coast are invaluable writings
that await translation.

Quem colorem habet sapientia?'

Evan S. Connell

 

Re: cvs commit: xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql XSPSQLLibrary.java

[Donald Ball <ba...@webslingerZ.com>]

On Thu, 22 Jun 2000, Mark Washeim wrote:

> Though, it actually makes a great deal of sense. Namely, unless you're
> planning on executing the sql 'manually', you need something in the response
> that 'tersely' expresses sucess. Or so I'm lead to believe in playing with
> this... thanks for you work on it, it's GREAT!

sure, but i reckon it's better to succeed silently than to fail with a
confusing error message.

- donald