You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by David Lutterkort <lu...@redhat.com> on 2012/08/25 03:13:40 UTC

[PATCH] Various fixes

Hi,

I uploaded a bunch of fixes to my apache page[1] and tracker[2], but one
of them is too big to be posted here, so you can look at them/review
them at these two places.

The patch series do the following:

      * switch the format for the deltacloudd config file to use string
        keys
      * make all Gogrid tests runnable individually with 'bundle exec
        ruby TEST'
      * change the Gogrid tests to read credentials from a config file
        (the same kind of file that the toplevel tests/ use, too)
      * try to make running tests from recordings faster by making
        wait_for! not sleep

David

[1] Individual patches http://people.apache.org/~lutter/patches/various-fixes/, 
    tarball http://people.apache.org/~lutter/patches/various-fixes.tgz
[2] http://tracker.deltacloud.org/set/26

Re: [PATCH] Various fixes

Posted by David Lutterkort <lu...@redhat.com>.
On Sat, 2012-08-25 at 10:13 +0200, Michal Fojtik wrote:
> On Aug 25, 2012, at 3:13 AM, David Lutterkort <lu...@redhat.com> wrote:
> 
> ACK to serie, these are working fine, no failures to me and tests run blazing fast ;-)

Thanks. Pushed these.

> # Running tests:
> 
> ............/Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:51: warning: class variable access from toplevel
> ./Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:51: warning: class variable access from top-level
> 
> Is it necessary to use @@ variable? Can't that be replaced by a method?

I moved the code into a class method - hopefully that fixes these
warnings.

David

Re: [PATCH] Various fixes

Posted by Michal Fojtik <mf...@redhat.com>.
On Aug 25, 2012, at 3:13 AM, David Lutterkort <lu...@redhat.com> wrote:

ACK to serie, these are working fine, no failures to me and tests run blazing fast ;-)

Just minor nit:

I got couple warning on gogrid tests:

[ rake drivers:gogrid ]
/Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:23: warning: class variable access from toplevel
/Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:25: warning: class variable access from toplevel
/Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:25: warning: class variable access from toplevel
Run options: 

# Running tests:

............/Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:51: warning: class variable access from toplevel
./Users/mfojtik/code/core/server/tests/drivers/gogrid/instances_test.rb:51: warning: class variable access from top-level

Is it necessary to use @@ variable? Can't that be replaced by a method?

  -- Michal

> Hi,
> 
> I uploaded a bunch of fixes to my apache page[1] and tracker[2], but one
> of them is too big to be posted here, so you can look at them/review
> them at these two places.
> 
> The patch series do the following:
> 
>      * switch the format for the deltacloudd config file to use string
>        keys
>      * make all Gogrid tests runnable individually with 'bundle exec
>        ruby TEST'
>      * change the Gogrid tests to read credentials from a config file
>        (the same kind of file that the toplevel tests/ use, too)
>      * try to make running tests from recordings faster by making
>        wait_for! not sleep
> 
> David
> 
> [1] Individual patches http://people.apache.org/~lutter/patches/various-fixes/, 
>    tarball http://people.apache.org/~lutter/patches/various-fixes.tgz
> [2] http://tracker.deltacloud.org/set/26
>