You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Konstantina Chremmou <ko...@citrix.com> on 2014/04/02 16:55:53 UTC

Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/
-----------------------------------------------------------

Review request for cloudstack and Alex Huang.


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.


Diffs
-----

  .gitignore d6f5d1c 
  deps/XenServerJava/pom.xml c9a4e86 
  deps/XenServerJava/src/LICENSE.Apache-2.0.txt 261eeb9 
  deps/XenServerJava/src/LICENSE.txt 76c4a22 
  deps/XenServerJava/src/README.txt 2e6fa45 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 9dcdd9f 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java 4778e6a 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java ec91d87 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 5a54ad2 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java 661724f 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java bb4440ae 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java 1d40d4d 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java bbca81c 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 9a4bfcd 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java 27db4a5 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 916d8b6 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 0bbae11 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 0f802f8 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java e93240e 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java 261933f 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java 0f229dc 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java b7483c1 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java 8cb4127 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java 9f8c929 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java bae095f 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java fbee50a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 43eadf5 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java e75b565 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java 7d15393 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 8b5c94d 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 99ac7e8 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java c9eaeaa 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 6950fcd 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java 8999158 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 418bb88 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java a00ab7d 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java 9a8fbfb 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 4a85dfe 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java e30bd0a 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 50f49a0 
  deps/XenServerJava/src/com/xensource/xenapi/User.java 4a01d60 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 72edf38 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java a58e5e0 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 1431ce0 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java ebd0a64 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java 075ec18 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java c755dc4 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java c051e53 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java f0abe29 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java 6ed76af 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java a0eb0d6 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 024f6c4 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 30f4984 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java f49019b 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 4ee7b2f 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java 815a874 
  plugins/hypervisors/ovm/pom.xml e03dac6 
  plugins/hypervisors/xen/pom.xml 39c0908 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java 6a8d1cd 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625StorageProcessor.java dad3d14 
  plugins/hypervisors/xen/src/org/apache/cloudstack/hypervisor/xenserver/XenServerResourceNewBase.java ec203d8 
  pom.xml c608c4b 

Diff: https://reviews.apache.org/r/19922/diff/


Testing
-------


Thanks,

Konstantina Chremmou


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Konstantina Chremmou <ko...@citrix.com>.

> On April 2, 2014, 8:54 p.m., Alex Huang wrote:
> > Please resubmit the patch for master.  It doesn't apply on master.  It looks to be fine for 4.4 but currently 4.4 is not building so I will get it applied once 4.4. is compiling.

I've just seen the patch went into master too, so I take it no resubmission is needed. Thanks for applying it.


- Konstantina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/#review39351
-----------------------------------------------------------


On April 2, 2014, 2:59 p.m., Konstantina Chremmou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19922/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:59 p.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.
> 
> 
> Diffs
> -----
> 
>   .gitignore d6f5d1c 
>   deps/XenServerJava/pom.xml c9a4e86 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt 261eeb9 
>   deps/XenServerJava/src/LICENSE.txt 76c4a22 
>   deps/XenServerJava/src/README.txt 2e6fa45 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 9dcdd9f 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java 4778e6a 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java ec91d87 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 5a54ad2 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java 661724f 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java bb4440ae 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java 1d40d4d 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java bbca81c 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 9a4bfcd 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java 27db4a5 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 916d8b6 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 0bbae11 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 0f802f8 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java e93240e 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java 261933f 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java 0f229dc 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java b7483c1 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java 8cb4127 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java 9f8c929 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java bae095f 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java fbee50a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 43eadf5 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java e75b565 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java 7d15393 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 8b5c94d 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 99ac7e8 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java c9eaeaa 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 6950fcd 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java 8999158 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 418bb88 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java a00ab7d 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java 9a8fbfb 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 4a85dfe 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java e30bd0a 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 50f49a0 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java 4a01d60 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 72edf38 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java a58e5e0 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 1431ce0 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java ebd0a64 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java 075ec18 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java c755dc4 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java c051e53 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java f0abe29 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java 6ed76af 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java a0eb0d6 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 024f6c4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 30f4984 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java f49019b 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 4ee7b2f 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java 815a874 
>   plugins/hypervisors/ovm/pom.xml e03dac6 
>   plugins/hypervisors/xen/pom.xml 39c0908 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java 6a8d1cd 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625StorageProcessor.java dad3d14 
>   plugins/hypervisors/xen/src/org/apache/cloudstack/hypervisor/xenserver/XenServerResourceNewBase.java ec203d8 
>   pom.xml c608c4b 
> 
> Diff: https://reviews.apache.org/r/19922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konstantina Chremmou
> 
>


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Alex Huang <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/#review39351
-----------------------------------------------------------


Please resubmit the patch for master.  It doesn't apply on master.  It looks to be fine for 4.4 but currently 4.4 is not building so I will get it applied once 4.4. is compiling.

- Alex Huang


On April 2, 2014, 2:59 p.m., Konstantina Chremmou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19922/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:59 p.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.
> 
> 
> Diffs
> -----
> 
>   .gitignore d6f5d1c 
>   deps/XenServerJava/pom.xml c9a4e86 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt 261eeb9 
>   deps/XenServerJava/src/LICENSE.txt 76c4a22 
>   deps/XenServerJava/src/README.txt 2e6fa45 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 9dcdd9f 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java 4778e6a 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java ec91d87 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 5a54ad2 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java 661724f 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java bb4440ae 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java 1d40d4d 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java bbca81c 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 9a4bfcd 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java 27db4a5 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 916d8b6 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 0bbae11 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 0f802f8 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java e93240e 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java 261933f 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java 0f229dc 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java b7483c1 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java 8cb4127 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java 9f8c929 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java bae095f 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java fbee50a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 43eadf5 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java e75b565 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java 7d15393 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 8b5c94d 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 99ac7e8 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java c9eaeaa 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 6950fcd 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java 8999158 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 418bb88 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java a00ab7d 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java 9a8fbfb 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 4a85dfe 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java e30bd0a 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 50f49a0 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java 4a01d60 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 72edf38 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java a58e5e0 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 1431ce0 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java ebd0a64 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java 075ec18 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java c755dc4 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java c051e53 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java f0abe29 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java 6ed76af 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java a0eb0d6 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 024f6c4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 30f4984 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java f49019b 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 4ee7b2f 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java 815a874 
>   plugins/hypervisors/ovm/pom.xml e03dac6 
>   plugins/hypervisors/xen/pom.xml 39c0908 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java 6a8d1cd 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625StorageProcessor.java dad3d14 
>   plugins/hypervisors/xen/src/org/apache/cloudstack/hypervisor/xenserver/XenServerResourceNewBase.java ec203d8 
>   pom.xml c608c4b 
> 
> Diff: https://reviews.apache.org/r/19922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konstantina Chremmou
> 
>


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Alex Huang <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/#review39353
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Huang


On April 2, 2014, 2:59 p.m., Konstantina Chremmou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19922/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:59 p.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.
> 
> 
> Diffs
> -----
> 
>   .gitignore d6f5d1c 
>   deps/XenServerJava/pom.xml c9a4e86 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt 261eeb9 
>   deps/XenServerJava/src/LICENSE.txt 76c4a22 
>   deps/XenServerJava/src/README.txt 2e6fa45 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 9dcdd9f 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java 4778e6a 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java ec91d87 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 5a54ad2 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java 661724f 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java bb4440ae 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java 1d40d4d 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java bbca81c 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 9a4bfcd 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java 27db4a5 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 916d8b6 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 0bbae11 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 0f802f8 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java e93240e 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java 261933f 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java 0f229dc 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java b7483c1 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java 8cb4127 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java 9f8c929 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java bae095f 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java fbee50a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 43eadf5 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java e75b565 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java 7d15393 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 8b5c94d 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 99ac7e8 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java c9eaeaa 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 6950fcd 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java 8999158 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 418bb88 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java a00ab7d 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java 9a8fbfb 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 4a85dfe 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java e30bd0a 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 50f49a0 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java 4a01d60 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 72edf38 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java a58e5e0 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 1431ce0 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java ebd0a64 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java 075ec18 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java c755dc4 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java c051e53 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java f0abe29 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java 6ed76af 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java a0eb0d6 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 024f6c4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 30f4984 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java f49019b 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 4ee7b2f 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java 815a874 
>   plugins/hypervisors/ovm/pom.xml e03dac6 
>   plugins/hypervisors/xen/pom.xml 39c0908 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java 6a8d1cd 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625StorageProcessor.java dad3d14 
>   plugins/hypervisors/xen/src/org/apache/cloudstack/hypervisor/xenserver/XenServerResourceNewBase.java ec203d8 
>   pom.xml c608c4b 
> 
> Diff: https://reviews.apache.org/r/19922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konstantina Chremmou
> 
>


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Alex Huang <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/#review40150
-----------------------------------------------------------


Tina,

I missed this on the first review.  The current change adds xen-api.jar as a dependency for every single package in CloudStack.  It should only be for the xenserver related packages.  Can you resubmit with that tested?  I think you just need to remove it from the cloudstack main pom.xml but best to test it.

Thanks.

--Alex

- Alex Huang


On April 9, 2014, 10:20 a.m., Konstantina Chremmou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19922/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 10:20 a.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.
> 
> 
> Diffs
> -----
> 
>   pom.xml c608c4b 
> 
> Diff: https://reviews.apache.org/r/19922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konstantina Chremmou
> 
>


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Konstantina Chremmou <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/
-----------------------------------------------------------

(Updated April 11, 2014, 2:44 p.m.)


Review request for cloudstack and Alex Huang.


Changes
-------

Removed xen-api dependency from the main pom.xml.


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.


Diffs (updated)
-----

  pom.xml 3fad07a 

Diff: https://reviews.apache.org/r/19922/diff/


Testing
-------


Thanks,

Konstantina Chremmou


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Konstantina Chremmou <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/
-----------------------------------------------------------

(Updated April 9, 2014, 10:20 a.m.)


Review request for cloudstack and Alex Huang.


Changes
-------

I have uploaded a new version of the xapi jar to the central repository with corrected dependency on xmlrpc 3.1.3 and here is the patch for it. I expect this to fix the errors caused by the previous patch.

Perhaps it would be safer to leave the whole thing out of 4.4 since we're past code complete, but please apply on master (where the previous patch has not been reverted) and retest. Thanks.


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.


Diffs (updated)
-----

  pom.xml c608c4b 

Diff: https://reviews.apache.org/r/19922/diff/


Testing
-------


Thanks,

Konstantina Chremmou


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/#review39358
-----------------------------------------------------------


Commit c1c2be423099c786ccfabf960c25f651f4e19928 in cloudstack's branch refs/heads/master from unknown
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c1c2be4 ]

CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.


- ASF Subversion and Git Services


On April 2, 2014, 2:59 p.m., Konstantina Chremmou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19922/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:59 p.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.
> 
> 
> Diffs
> -----
> 
>   .gitignore d6f5d1c 
>   deps/XenServerJava/pom.xml c9a4e86 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt 261eeb9 
>   deps/XenServerJava/src/LICENSE.txt 76c4a22 
>   deps/XenServerJava/src/README.txt 2e6fa45 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 9dcdd9f 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java 4778e6a 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java ec91d87 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 5a54ad2 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java 661724f 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java bb4440ae 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java 1d40d4d 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java bbca81c 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 9a4bfcd 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java 27db4a5 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 916d8b6 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 0bbae11 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 0f802f8 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java e93240e 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java 261933f 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java 0f229dc 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java b7483c1 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java 8cb4127 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java 9f8c929 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java bae095f 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java fbee50a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 43eadf5 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java e75b565 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java 7d15393 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 8b5c94d 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 99ac7e8 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java c9eaeaa 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 6950fcd 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java 8999158 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 418bb88 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java a00ab7d 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java 9a8fbfb 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 4a85dfe 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java e30bd0a 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 50f49a0 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java 4a01d60 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 72edf38 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java a58e5e0 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 1431ce0 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java ebd0a64 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java 075ec18 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java c755dc4 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java c051e53 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java f0abe29 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java 6ed76af 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java a0eb0d6 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 024f6c4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 30f4984 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java f49019b 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 4ee7b2f 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java 815a874 
>   plugins/hypervisors/ovm/pom.xml e03dac6 
>   plugins/hypervisors/xen/pom.xml 39c0908 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java 6a8d1cd 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625StorageProcessor.java dad3d14 
>   plugins/hypervisors/xen/src/org/apache/cloudstack/hypervisor/xenserver/XenServerResourceNewBase.java ec203d8 
>   pom.xml c608c4b 
> 
> Diff: https://reviews.apache.org/r/19922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konstantina Chremmou
> 
>


Re: Review Request 19922: CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead.

Posted by Konstantina Chremmou <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19922/
-----------------------------------------------------------

(Updated April 2, 2014, 2:59 p.m.)


Review request for cloudstack and Alex Huang.


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6251: Removed XenServer stub code and used xapi.jar from the central repository instead. Also: fixed typo; ignored file.


Diffs
-----

  .gitignore d6f5d1c 
  deps/XenServerJava/pom.xml c9a4e86 
  deps/XenServerJava/src/LICENSE.Apache-2.0.txt 261eeb9 
  deps/XenServerJava/src/LICENSE.txt 76c4a22 
  deps/XenServerJava/src/README.txt 2e6fa45 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 9dcdd9f 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java 4778e6a 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java ec91d87 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 5a54ad2 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java 661724f 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java bb4440ae 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java 1d40d4d 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java bbca81c 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 9a4bfcd 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java 27db4a5 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 916d8b6 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 0bbae11 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 0f802f8 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java e93240e 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java 261933f 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java 0f229dc 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java b7483c1 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java 8cb4127 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java 9f8c929 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java bae095f 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java fbee50a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 43eadf5 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java e75b565 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java 7d15393 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 8b5c94d 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 99ac7e8 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java c9eaeaa 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 6950fcd 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java 8999158 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 418bb88 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java a00ab7d 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java 9a8fbfb 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 4a85dfe 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java e30bd0a 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 50f49a0 
  deps/XenServerJava/src/com/xensource/xenapi/User.java 4a01d60 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 72edf38 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java a58e5e0 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 1431ce0 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java ebd0a64 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java 075ec18 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java c755dc4 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java c051e53 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java f0abe29 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java 6ed76af 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java a0eb0d6 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 024f6c4 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 30f4984 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java f49019b 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 4ee7b2f 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java 815a874 
  plugins/hypervisors/ovm/pom.xml e03dac6 
  plugins/hypervisors/xen/pom.xml 39c0908 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java 6a8d1cd 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625StorageProcessor.java dad3d14 
  plugins/hypervisors/xen/src/org/apache/cloudstack/hypervisor/xenserver/XenServerResourceNewBase.java ec203d8 
  pom.xml c608c4b 

Diff: https://reviews.apache.org/r/19922/diff/


Testing
-------


Thanks,

Konstantina Chremmou