You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by zi...@apache.org on 2022/05/11 18:36:18 UTC
[gobblin] branch master updated: GOBBLIN-1644 (#3506)
This is an automated email from the ASF dual-hosted git repository.
zihanli58 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git
The following commit(s) were added to refs/heads/master by this push:
new 5ad9fe159 GOBBLIN-1644 (#3506)
5ad9fe159 is described below
commit 5ad9fe1593d196d825741cedbaeb7b4d5d015226
Author: Matthew Ho <ho...@gmail.com>
AuthorDate: Wed May 11 11:36:12 2022 -0700
GOBBLIN-1644 (#3506)
Log assigned participant when helix participant check fails
---
.../java/org/apache/gobblin/cluster/GobblinClusterManager.java | 2 +-
.../org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java | 8 +++++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
index 258ef2aa3..c7b74fe92 100644
--- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
+++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
@@ -239,7 +239,7 @@ public class GobblinClusterManager implements ApplicationLauncher, StandardMetri
/**
* Configure Helix quota-based task scheduling.
* This config controls the number of tasks that are concurrently assigned to a single Helix instance.
- * Reference: https://helix.apache.org/0.9.1-docs/quota_scheduling.html
+ * Reference: https://helix.apache.org/1.0.3-docs/quota_scheduling.html
*/
@VisibleForTesting
void configureHelixQuotaBasedTaskScheduling() {
diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java
index 9aa1eebe2..4017143b7 100644
--- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java
+++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java
@@ -140,7 +140,13 @@ public class HelixAssignedParticipantCheck implements CommitStep {
if (jobContext != null) {
String participant = jobContext.getAssignedParticipant(partitionNum);
if (participant != null) {
- return participant.equalsIgnoreCase(helixInstanceName);
+ boolean isAssignedParticipant = participant.equalsIgnoreCase(helixInstanceName);
+ if (!isAssignedParticipant) {
+ log.info("The current helix instance is not the assigned participant. helixInstanceName={}, assignedParticipant={}",
+ helixInstanceName, participant);
+ }
+
+ return isAssignedParticipant;
}
}
return false;