[jira] [Commented] (SCB-331) Log optimization

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354878#comment-16354878 ] 

ASF GitHub Bot commented on SCB-331:
------------------------------------

laijianbin opened a new pull request #551: [SCB-331] log optimization
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/551
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Log optimization
> ----------------
>
>                 Key: SCB-331
>                 URL: https://issues.apache.org/jira/browse/SCB-331
>             Project: Apache ServiceComb
>          Issue Type: Task
>            Reporter: laijianbin
>            Assignee: laijianbin
>            Priority: Major
>
> public static DynamicWatchedConfiguration createConfigFromConfigCenter(Configuration localConfiguration) {
>  if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)