You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by thunterdb <gi...@git.apache.org> on 2015/11/13 19:19:00 UTC
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
GitHub user thunterdb opened a pull request:
https://github.com/apache/spark/pull/9697
[SPARK-11732] Removes some MiMa false positives
This adds an extra filter for private or protected classes. We only filter for package private right now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thunterdb/spark spark-11732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9697.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9697
----
commit 0eb30e25739687adb721ed1d511a905bd5992503
Author: Timothy Hunter <ti...@databricks.com>
Date: 2015-11-13T18:15:02Z
SPARK-11732 #comment link with jira
commit 7d609ca165053ff47ae0617507c746beb4c61c79
Author: Timothy Hunter <ti...@databricks.com>
Date: 2015-11-13T18:16:37Z
remove excludes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9697#issuecomment-156559714
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9697#discussion_r44837519
--- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala ---
@@ -72,7 +72,10 @@ object GenerateMIMAIgnore {
val classSymbol = mirror.classSymbol(Class.forName(className, false, classLoader))
val moduleSymbol = mirror.staticModule(className)
val directlyPrivateSpark =
- isPackagePrivate(classSymbol) || isPackagePrivateModule(moduleSymbol)
+ isPackagePrivate(classSymbol) ||
+ isPackagePrivateModule(moduleSymbol) ||
+ classSymbol.isPrivate ||
+ classSymbol.isProtected
--- End diff --
You also added `protected` here though; I'm not sure that's safe to exclude from checks.
The point is that some previous excludes are now caught by the new `isPrivate` check and ignored?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9697#issuecomment-156559517
**[Test build #45875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45875/consoleFull)** for PR 9697 at commit [`39a59bd`](https://github.com/apache/spark/commit/39a59bd04560a2ddced7028e4e115b4308f6359f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:\n * `public class JavaGradientBoostingClassificationExample `\n * `public class JavaGradientBoostingRegressionExample `\n * `public class JavaRandomForestClassificationExample `\n * `public class JavaRandomForestRegressionExample `\n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9697#issuecomment-156559717
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45875/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9697#issuecomment-156510848
**[Test build #45875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45875/consoleFull)** for PR 9697 at commit [`39a59bd`](https://github.com/apache/spark/commit/39a59bd04560a2ddced7028e4e115b4308f6359f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...
Posted by thunterdb <gi...@git.apache.org>.
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/9697#issuecomment-156507620
cc @pwendell @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org