[Bug 62147] New: tokens resource collection expands properties

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62147

            Bug ID: 62147
           Summary: tokens resource collection expands properties
           Product: Ant
           Version: 1.10.2
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core
          Assignee: notifications@ant.apache.org
          Reporter: erik.deweerdt@luciad.com
  Target Milestone: ---

Created attachment 35748
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35748&action=edit
Simple build.xml demonstrating the regression

The tokens resource collection was subtly changed from Ant 1.9 to 1.10 in that
it now expands properties. This is unexpected and not documented, so I suspect
it may be an unintentional change.

The attached build.xml demonstrates the problem. When run with Ant 1.9.7 the
properties are not expanded, with Ant 1.10.2 they are.

This is likely due to a changed call to StringResource in
org.apache.tools.ant.types.resources.Tokens#getCollection. The project is now
passed as a parameter (it was not in 1.9), resulting in the property-expanding
constructor being called.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 62147] tokens resource collection expands properties

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62147

Jaikiran Pai <ja...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Jaikiran Pai <ja...@apache.org> ---
You are right - we did introduce some regressions in our recent release due to
some of our refactoring changes. This is one of them. 

I have now reverted this behaviour to what it was previously and included a
test, similar to the one you provide in your example and have committed it to
upstream. The fix should be available in our next release.

Thank you for reporting this and providing an example to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 62147] tokens resource collection expands properties

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62147

Jaikiran Pai <ja...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.10.3

-- 
You are receiving this mail because:
You are the assignee for the bug.