You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/27 21:49:40 UTC

[jira] [Commented] (TS-4157) traffic_via uses files names in it tests that are illegal on shared drives

    [ https://issues.apache.org/jira/browse/TS-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120138#comment-15120138 ] 

ASF GitHub Bot commented on TS-4157:
------------------------------------

GitHub user dragon512 opened a pull request:

    https://github.com/apache/trafficserver/pull/440

    [TS-4157] traffic_via tests use bad characters in the file name

    Changed the usage of : to ; which seems to be more filename friendly.
    Changed test files to have ; in them

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dragon512/trafficserver master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #440
    
----
commit 561a80ea57bef2d53b3ffb0d3eff450b6a05bc69
Author: dragon512 <dr...@live.com>
Date:   2016-01-26T21:07:29Z

    Update traffic_via.cc
    
    Change use of : to ; as this character is safer to use on shared drives with different OS

commit c1c578fd01838177a9695f358f739f8b44619c0f
Author: Jason Kenny <jk...@yahoo-inc.com>
Date:   2016-01-27T20:30:34Z

    changed test files to use ; intsead of :

----


> traffic_via uses files names in it tests that are illegal on shared drives
> --------------------------------------------------------------------------
>
>                 Key: TS-4157
>                 URL: https://issues.apache.org/jira/browse/TS-4157
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Jason Kenny
>
> traffic_via has a test directory which file uses names with a : in it. This value will not work on shared drivers as : is an illegal character. This makes certain cases in which it is nice to check out traffic server on shared drives impossible. fixing this to not use : would make life better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)