You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/11/06 07:02:40 UTC

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4503: [ZEPPELIN-5842] Maven-Plugin management

jongyoul commented on code in PR #4503:
URL: https://github.com/apache/zeppelin/pull/4503#discussion_r1014779148


##########
zeppelin-integration/pom.xml:
##########
@@ -37,14 +37,9 @@
   </prerequisites>
 
   <properties>
-    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Review Comment:
   I read https://maven.apache.org/plugins/maven-resources-plugin/examples/encoding.html and found we are using system-dependent encoding. Is it ok? Otherwise, is it better to set UTF-8 in a root pom? WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org