You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/10/21 20:04:27 UTC

Review Request 39519: Create a script to change host names for a stopped cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.


> On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote:
> > ambari-server/sbin/ambari-server, line 147
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102446#file1102446line147>
> >
> >     Lets call this update-hostname

Renamed to update-host-names


> On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, line 174
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102449#file1102449line174>
> >
> >     Should there be an option to updated older configurations and not just the selected ones ?

Need to discuss this with Sumit. I don't think we need that/ Will ask in jira.


> On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, line 351
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102449#file1102449line351>
> >
> >     What about config group associatons, are those by id ?

There we are using host id.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103527
-----------------------------------------------------------


On Жов. 22, 2015, 11:46 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Жов. 22, 2015, 11:46 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sid Wagle <sw...@hortonworks.com>.


On Oct. 22, 2015, 5:22 a.m., Vitalyi Brodetskyi wrote:
> > Any reason to not have written unit tests for this?

Ignore this, just saw the update.


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103527
-----------------------------------------------------------


On Oct. 21, 2015, 6:04 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 6:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sid Wagle <sw...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103527
-----------------------------------------------------------



ambari-server/sbin/ambari-server (line 147)
<https://reviews.apache.org/r/39519/#comment161575>

    Lets call this update-hostname



ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java (line 174)
<https://reviews.apache.org/r/39519/#comment161576>

    Should there be an option to updated older configurations and not just the selected ones ?



ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java (line 351)
<https://reviews.apache.org/r/39519/#comment161578>

    What about config group associatons, are those by id ?


Any reason to not have written unit tests for this?

- Sid Wagle


On Oct. 21, 2015, 6:04 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 6:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sumit Mohanty <sm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103952
-----------------------------------------------------------



ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java (line 257)
<https://reviews.apache.org/r/39519/#comment162059>

    Why are these being ignored? There are a few Ignore tests.


- Sumit Mohanty


On Oct. 24, 2015, 9:16 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 9:16 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 92cc9e6 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 482ac38 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b692368 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java d427e1a 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 1a9088c 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103992
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 25, 2015, 12:16 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2015, 12:16 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 92cc9e6 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 482ac38 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b692368 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java d427e1a 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 1a9088c 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review104014
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 26, 2015, 4:26 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 4:26 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sumit Mohanty <sm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review104103
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Oct. 26, 2015, 8:28 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 8:28 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 26, 2015, 8:28 після полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 26, 2015, 2:26 після полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 24, 2015, 9:16 після полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 92cc9e6 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 482ac38 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b692368 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java d427e1a 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 1a9088c 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 24, 2015, 8:30 після полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 04ab1ef 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 92cc9e6 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 482ac38 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b692368 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java d427e1a 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 1a9088c 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sumit Mohanty <sm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103807
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Oct. 23, 2015, 5:02 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 5:02 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 23, 2015, 5:02 після полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 22, 2015, 12:03 після полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 22, 2015, 11:59 до полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/
-----------------------------------------------------------

(Updated Жов. 22, 2015, 11:46 до полудня)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-13507
    https://issues.apache.org/jira/browse/AMBARI-13507


Repository: ambari


Description
-------

At a high-level we may follow this approach:
Ensure cluster is not kerberized
Assume all services to be stopped (add a check to ensure that services are stopped)
We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
Agents need to be re-configured if ambari-server hostname changes


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 1843cd6 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
  ambari-server/src/main/python/ambari-server.py 88df81a 
  ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 

Diff: https://reviews.apache.org/r/39519/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.


> On Жов. 22, 2015, 8:23 до полудня, Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, line 197
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102449#file1102449line197>
> >
> >     Seems dangerous to me.
> >     If customer's cluster has primitive hostnames without domain name (like host1, host2,.. host10 and so on), then replacing host1 will also affect host10 in configs.
> >     
> >     How about doing it via regex that enforces that there is no alfanumeric characters right after replacement?

Need to discuss that in jira.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103540
-----------------------------------------------------------


On Жов. 22, 2015, 11:46 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Жов. 22, 2015, 11:46 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103540
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 856)
<https://reviews.apache.org/r/39519/#comment161596>

    Let's output a full path to file here (easier troubleshooting)



ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java (line 197)
<https://reviews.apache.org/r/39519/#comment161597>

    Seems dangerous to me.
    If customer's cluster has primitive hostnames without domain name (like host1, host2,.. host10 and so on), then replacing host1 will also affect host10 in configs.
    
    How about doing it via regex that enforces that there is no alfanumeric characters right after replacement?


- Dmitro Lisnichenko


On Oct. 21, 2015, 9:04 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 9:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.


> On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote:
> > ambari-server/sbin/ambari-server, line 148
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102446#file1102446line148>
> >
> >     Updating hostnames

done


> On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, line 859
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102447#file1102447line859>
> >
> >     type - configuration
> 
> Sumit Mohanty wrote:
>     I meant typo.

done


> On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, line 355
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102449#file1102449line355>
> >
> >     How about topology_host_request table?

Added.


> On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/python/ambari_server/hostUpdate.py, line 39
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102452#file1102452line39>
> >
> >     Lets modify the texts in this function to say "update host name" instead of "update host".

done


> On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/python/ambari_server/hostUpdate.py, line 45
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102452#file1102452line45>
> >
> >     Lets ask if DB has been backed up and if the answer is N exit

added


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103530
-----------------------------------------------------------


On Жов. 22, 2015, 11:46 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Жов. 22, 2015, 11:46 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sumit Mohanty <sm...@hortonworks.com>.


> On Oct. 22, 2015, 6:14 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, line 859
> > <https://reviews.apache.org/r/39519/diff/1/?file=1102447#file1102447line859>
> >
> >     type - configuration

I meant typo.


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103530
-----------------------------------------------------------


On Oct. 21, 2015, 6:04 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 6:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 39519: Create a script to change host names for a stopped cluster

Posted by Sumit Mohanty <sm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39519/#review103530
-----------------------------------------------------------



ambari-server/sbin/ambari-server (line 148)
<https://reviews.apache.org/r/39519/#comment161580>

    Updating hostnames



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 854)
<https://reviews.apache.org/r/39519/#comment161581>

    type - configuration



ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java (line 355)
<https://reviews.apache.org/r/39519/#comment161584>

    How about topology_host_request table?



ambari-server/src/main/python/ambari_server/hostUpdate.py (line 39)
<https://reviews.apache.org/r/39519/#comment161582>

    Lets modify the texts in this function to say "update host name" instead of "update host".



ambari-server/src/main/python/ambari_server/hostUpdate.py (line 45)
<https://reviews.apache.org/r/39519/#comment161585>

    Lets ask if DB has been backed up and if the answer is N exit


- Sumit Mohanty


On Oct. 21, 2015, 6:04 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39519/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 6:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13507
>     https://issues.apache.org/jira/browse/AMBARI-13507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> At a high-level we may follow this approach:
> Ensure cluster is not kerberized
> Assume all services to be stopped (add a check to ensure that services are stopped)
> We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted
> Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com)
> As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code
> Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice)
> Agents need to be re-configured if ambari-server hostname changes
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 1843cd6 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 
>   ambari-server/src/main/python/ambari-server.py 88df81a 
>   ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea 
> 
> Diff: https://reviews.apache.org/r/39519/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>